Code review comment

Author: jigar-f

lib/features/report_issue/report_issue.dart

@@ -279,32 +279,51 @@ class _ReportIssueState extends ConsumerState<ReportIssue> {
 
     hideKeyboard();
 
+    // Snapshot the validated fields now so later edits (e.g. while the
+    // confirmation dialog is up or during its dismiss delay) can't change
+    // what gets sent.
+    final draft = ref.read(reportIssueDraftProvider);
+    final issueType = _selectedIssue ?? '';
+    final email = _emailController.text.trim();
+    final description = _descriptionController.text.trim();
+    final attachments = List<ReportIssueAttachment>.of(draft.attachments);
+
     // Without an email we can't reply or follow up, so confirm before sending.
-    if (_emailController.text.trim().isEmpty) {
+    if (email.isEmpty) {
       AppDialog.show(
         context: context,
         title: 'send_without_email_title'.i18n,
         body: 'send_without_email_body'.i18n,
         primaryLabel: 'add_email'.i18n,
         secondaryLabel: 'send_without_email'.i18n,
-        onSecondaryPressed: _performSubmit,
+        onSecondaryPressed: () => _performSubmit(
+          email: email,
+          issueType: issueType,
+          description: description,
+          attachments: attachments,
+        ),
       );
       return;
     }
 
-    await _performSubmit();
+    await _performSubmit(
+      email: email,
+      issueType: issueType,
+      description: description,
+      attachments: attachments,
+    );
   }
 
-  Future<void> _performSubmit() async {
+  Future<void> _performSubmit({
+    required String email,
+    required String issueType,
+    required String description,
+    required List<ReportIssueAttachment> attachments,
+  }) async {
     if (!mounted) {
       return;
     }
 
-    final draft = ref.read(reportIssueDraftProvider);
-    final issueType = _selectedIssue ?? '';
-    final email = _emailController.text.trim();
-    final description = _descriptionController.text.trim();
-
     context.showLoadingDialog();
     appLogger.debug('Submitting issue report: $issueType, $description');
 
@@ -314,7 +333,7 @@ class _ReportIssueState extends ConsumerState<ReportIssue> {
           email: email,
           issueType: issueType,
           description: description,
-          attachments: draft.attachments,
+          attachments: attachments,
         );
 
     if (!mounted) {

test/features/report_issue/report_issue_test.dart

@@ -300,6 +300,37 @@ void main() {
       expect(submitter.calls, isEmpty);
     });
 
+    testWidgets('submits the snapshot taken at validation time, not later '
+        'edits made during the confirmation flow', (tester) async {
+      await tester.pumpWidget(
+        buildScreen(screen: const ReportIssue(type: '0')),
+      );
+      await tester.pumpAndSettle();
+
+      final descriptionField = find.byKey(
+        const Key('report_issue.description'),
+      );
+      await tester.enterText(descriptionField, 'original description');
+      await tester.pump();
+
+      final submitButton = find.byKey(const Key('report_issue.submit_button'));
+      await tester.ensureVisible(submitButton);
+      await tester.tap(submitButton);
+      await tester.pumpAndSettle();
+
+      await tester.tap(find.text('send_without_email'));
+      await tester.pumpAndSettle();
+
+      // Edit the form during the dialog's dismiss delay, before the
+      // confirmed submit fires.
+      await tester.enterText(descriptionField, 'edited after confirming');
+      await tester.pump(const Duration(milliseconds: 400));
+      await tester.pumpAndSettle();
+
+      expect(submitter.calls, hasLength(1));
+      expect(submitter.calls.single.description, 'original description');
+    });
+
     testWidgets('skips the confirmation dialog when an email is provided', (
       tester,
     ) async {