Skip to content

Commit c2894c1

Browse files
myleshortonclaude
andcommitted
ci: run Android compile check only on Kotlin changes
Narrows android-compile-check.yml's pull_request paths to **/*.kt (plus the workflow self-trigger), down from android/**, lantern-core/**, go.mod/go.sum, Makefile, pubspec.*, and flutter-version.yaml. The expensive macos-26 debug-APK build now runs only when Kotlin source changes, not on every Go/Flutter/dependency PR. Trade-off: a Go/gomobile-AAR change that breaks the AAR<->Kotlin interface is no longer caught by this PR gate — it surfaces in build-android.yml / release. Header comment updated to match the narrowed scope. (main is not branch- protected, so this is not a required check — narrowing paths can't strand a required status.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 4e9a3ed commit c2894c1

1 file changed

Lines changed: 11 additions & 13 deletions

File tree

.github/workflows/android-compile-check.yml

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,22 @@
11
name: Android Compile Check
22

3-
# Gates PRs that touch Kotlin/Android (or the Go/deps that produce the gomobile
4-
# AAR the Kotlin compiles against) by building the debug APK — which compiles
5-
# all app Kotlin. The full signed release build (build-android.yml) is
6-
# workflow_call-only and never ran on PRs, so a Kotlin compile break (e.g. the
7-
# bare success() call in #8754) could merge to main undetected. This catches it.
3+
# Compiles all app Kotlin (by building the debug APK) on PRs that change Kotlin
4+
# source, to catch Kotlin compile breaks before they reach main. The full signed
5+
# release build (build-android.yml) is workflow_call-only and never runs on PRs,
6+
# so without this gate a Kotlin break (e.g. the bare success() call in #8754)
7+
# could merge undetected.
8+
#
9+
# Scope: triggers only on Kotlin (*.kt) changes. It intentionally does NOT run on
10+
# Go/gomobile-AAR or Flutter/dep changes — a Go change that breaks the
11+
# AAR<->Kotlin interface would surface in build-android.yml / release, not here.
812
#
913
# Debug build only: no keystore/APP_ENV secrets, no AAB, no artifact upload.
1014

1115
on:
1216
pull_request:
1317
paths:
14-
- "android/**"
15-
- "lantern-core/**"
16-
- "go.mod"
17-
- "go.sum"
18-
- "Makefile"
19-
- "pubspec.yaml"
20-
- "pubspec.lock"
21-
- ".github/flutter-version.yaml"
18+
- "**/*.kt"
19+
# keep the self-trigger so edits to this workflow re-run it
2220
- ".github/workflows/android-compile-check.yml"
2321

2422
concurrency:

0 commit comments

Comments
 (0)