Skip to content

Commit daa7335

Browse files
authored
code review updates (#8858)
1 parent 6a93a28 commit daa7335

1 file changed

Lines changed: 14 additions & 0 deletions

File tree

windows/CMakeLists.txt

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,20 @@ add_subdirectory("runner")
5656
# them to the application.
5757
include(flutter/generated_plugins.cmake)
5858

59+
# VS 18 rejects C++/WinRT's C++17 coroutine fallback in these plugins. The
60+
# released plugin sources are not C++20-clean, so scope the compatibility define
61+
# to the affected targets instead of changing their language mode.
62+
foreach(TARGET
63+
flutter_inappwebview_windows_plugin
64+
flutter_local_notifications_windows
65+
)
66+
if(TARGET ${TARGET})
67+
target_compile_definitions(${TARGET} PRIVATE
68+
_SILENCE_EXPERIMENTAL_COROUTINE_DEPRECATION_WARNINGS
69+
)
70+
endif()
71+
endforeach()
72+
5973

6074
# === Installation ===
6175
# Support files are copied into place next to the executable, so that it can

0 commit comments

Comments
 (0)