Fix version reporting: make Version a var for ldflags injection (#359)

* fix: make Version a var so ldflags can inject it at build time

Version was a const, which Go ldflags cannot override. This meant all
builds reported "9.0.1" regardless of actual release version. Change
it to a var and remove the redundant AppVersion var.

The lantern Makefile ldflags should target common.Version directly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: 3 people

backend/headers.go

@@ -43,7 +43,7 @@ func NewRequestWithHeaders(ctx context.Context, method, url string, body io.Read
 	// based on consistent packet lengths.
 	req.Header.Add(RandomNoiseHeader, randomizedString())
 
-	req.Header.Set(AppVersionHeader, common.AppVersion)
+	req.Header.Set(AppVersionHeader, common.Version)
 	req.Header.Set(VersionHeader, common.Version)
 	req.Header.Set(UserIDHeader, strconv.FormatInt(settings.GetInt64(settings.UserIDKey), 10))
 	req.Header.Set(PlatformHeader, common.Platform)

common/constants.go

@@ -4,9 +4,13 @@ import (
 	"time"
 )
 
+// Version is the application version, injected at build time via ldflags:
+//
+//	-X 'github.com/getlantern/radiance/common.Version=x.y.z'
+var Version = "dev"
+
 const (
-	Name    = "lantern"
-	Version = "9.0.1"
+	Name = "lantern"
 
 	// filenames
 	LogFileName        = "lantern.log"
@@ -21,7 +25,6 @@ const (
 	StageBaseURL      = "https://api.staging.iantem.io/v1"
 )
 
-var AppVersion = Version
 
 // GetProServerURL returns the pro server URL based on the current environment.
 func GetProServerURL() string {

telemetry/otel.go

@@ -88,7 +88,7 @@ func initialize(deviceID string, configResponse common.ConfigResponse, pro bool)
 	attrs := Attributes{
 		App:        "radiance",
 		DeviceID:   deviceID,
-		AppVersion: rcommon.AppVersion,
+		AppVersion: rcommon.Version,
 		Platform:   rcommon.Platform,
 		GoVersion:  runtime.Version(),
 		OSName:     runtime.GOOS,