Merge pull request #349 from cmcnicholas/feature/fix-alarm-naming

Fix #348 topic display name too long

Author: mnapoli

src/constructs/aws/Queue.ts

@@ -254,9 +254,12 @@ export class Queue extends AwsConstruct {
 
         const alarmEmail = configuration.alarm;
         if (alarmEmail !== undefined) {
+            // generate the display name, AWS restriction is 100 chars
+            const displayName = `[Alert][${id}] failed jobs in the DLQ.`.substring(0, 100);
+
             const alarmTopic = new Topic(this, "AlarmTopic", {
                 topicName: `${this.provider.stackName}-${id}-dlq-alarm-topic`,
-                displayName: `[Alert][${id}] There are failed jobs in the dead letter queue.`,
+                displayName,
             });
             new Subscription(this, "AlarmTopicSubscription", {
                 topic: alarmTopic,

test/unit/queues.test.ts

@@ -418,7 +418,7 @@ describe("queues", () => {
             Properties: {
                 // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
                 TopicName: expect.stringMatching(/test-queues-\w+-dev-emails-dlq-alarm-topic/),
-                DisplayName: "[Alert][emails] There are failed jobs in the dead letter queue.",
+                DisplayName: "[Alert][emails] failed jobs in the DLQ.",
             },
         });
         expect(cfTemplate.Resources[computeLogicalId("emails", "AlarmTopicSubscription")]).toMatchObject({