Fixes error messages

Author: latin-panda

packages/scenario/test/smoketests/child-vaccination.test.ts

@@ -102,7 +102,7 @@ class Scenario extends BaseScenario {
 		const currentPosition = this.getSelectedPositionalEvent();
 
 		if (currentPosition.eventType === 'END_OF_FORM') {
-			throw 'todo';
+			throw new Error('Cannot proceed. Reached the end of the form.');
 		}
 
 		const events = this.getPositionalEvents();
@@ -138,7 +138,7 @@ class Scenario extends BaseScenario {
 		const next = this.getNextEventPosition();
 
 		if (next.eventType === 'END_OF_FORM') {
-			throw 'todo';
+			throw new Error('Cannot proceed. Reached the end of the form.');
 		}
 
 		return new JRTreeReference(next.node.currentState.reference);

packages/xpath/src/evaluator/expression/UnionExpressionEvaluator.ts

@@ -23,13 +23,13 @@ export class UnionExpressionEvaluator extends LocationPathExpressionEvaluator {
 		const lhs = this.lhs.evaluate(context);
 
 		if (!(lhs instanceof LocationPathEvaluation)) {
-			throw 'todo lhs not node-set result';
+			throw new Error('Left-hand side expression did not evaluate to a node-set.');
 		}
 
 		const rhs = this.rhs.evaluate(context);
 
 		if (!(rhs instanceof LocationPathEvaluation)) {
-			throw 'todo rhs not node-set result';
+			throw new Error('Right-hand side expression did not evaluate to a node-set.');
 		}
 
 		const nodes = Array.from(new Set([...lhs.nodes, ...rhs.nodes]));

packages/xpath/src/evaluator/result/toXPathEvaluationResult.ts

@@ -67,15 +67,15 @@ export const toXPathEvaluationResult = <T extends XPathNode>(
 		case ANY_UNORDERED_NODE_TYPE:
 		case FIRST_ORDERED_NODE_TYPE:
 			if (nodes == null) {
-				throw 'todo not a node-set';
+				throw new Error('Expected a node-set for node iterator result, but received null.');
 			}
 
 			return new NodeSetIteratorResult(domProvider, resultType, nodes);
 
 		case UNORDERED_NODE_SNAPSHOT_TYPE:
 		case ORDERED_NODE_SNAPSHOT_TYPE:
 			if (nodes == null) {
-				throw 'todo not a node-set';
+				throw new Error('Expected a node-set for node snapshot result, but received null.');
 			}
 
 			return new NodeSetSnapshotResult(domProvider, resultType, nodes);

packages/xpath/src/functions/fn/node-set.ts

@@ -11,7 +11,7 @@ export const count = new NumberFunction(
 		const results = expression!.evaluate(context);
 
 		if (results.nodes == null) {
-			throw 'todo not a node-set';
+			throw new Error('Expected a node-set for count function, but received null.');
 		}
 
 		return new Set(results.nodes).size;
@@ -64,7 +64,7 @@ export const localName = new StringFunction(
 		const evaluated = expression?.evaluate(context) ?? context;
 
 		if (!(evaluated instanceof LocationPathEvaluation)) {
-			throw 'todo not a node-set';
+			throw new Error('Expected a node-set for local-name function, but received an invalid type.');
 		}
 
 		const node = evaluated.first()?.value;
@@ -95,7 +95,7 @@ export const name = new StringFunction(
 		const evaluated = expression?.evaluate(context) ?? context;
 
 		if (!(evaluated instanceof LocationPathEvaluation)) {
-			throw 'todo not a node-set';
+			throw new Error('Expected a node-set for name function, but received an invalid type.');
 		}
 
 		const node = evaluated.first()?.value;
@@ -125,7 +125,7 @@ export const namespaceURI = new StringFunction(
 		const evaluated = expression?.evaluate(context) ?? context;
 
 		if (!(evaluated instanceof LocationPathEvaluation)) {
-			throw 'todo not a node-set';
+			throw new Error('Expected a node-set for namespace-uri function, but received an invalid type.');
 		}
 
 		const node = evaluated.first()?.value;

packages/xpath/src/functions/xforms/boolean.ts

@@ -78,7 +78,7 @@ export const weightedChecklist = new BooleanFunction(
 			const weightExpression = expressions[i + 1];
 
 			if (weightExpression == null) {
-				throw 'todo';
+				throw new Error('The weighted-checklist function must be given an even number of arguments.');
 			}
 
 			const results = expression.evaluate(context).values();

packages/xpath/src/functions/xforms/datetime.ts

@@ -239,7 +239,7 @@ const evaluateDateTime = <T extends XPathNode>(
 		}
 
 		default:
-			throw 'todo';
+			throw new Error('Expected a NUMBER or STRING evaluation type for date-time conversion, but received an invalid type.');
 	}
 };
 

packages/xpath/src/functions/xforms/node-set.ts

@@ -17,7 +17,7 @@ export const countNonEmpty = new NumberFunction(
 		const results = expression!.evaluate(context);
 
 		if (results.type !== 'NODE') {
-			throw 'todo';
+			throw new Error('Expected a node-set for count-non-empty function, but received an invalid type.');
 		}
 
 		let result = 0;
@@ -252,7 +252,7 @@ export const once = new StringFunction(
 		const [contextNode] = context.contextNodes;
 
 		if (contextNode == null) {
-			throw 'todo once no context';
+			throw new Error('No context node available for the once function.');
 		}
 
 		const string = context.domProvider.getNodeValue(contextNode);
@@ -324,7 +324,7 @@ export const position = new NumberFunction(
 		}
 
 		if (next != null) {
-			throw 'todo enforce single node(?)';
+			throw new Error('Expected a single node for position function, but multiple nodes were provided.');
 		}
 
 		const { domProvider } = context;

packages/xpath/src/functions/xforms/string.ts

@@ -248,7 +248,7 @@ export const uuid = new StringFunction(
 		const outputLength = lengthExpression.evaluate(context).toNumber();
 
 		if (Number.isNaN(outputLength)) {
-			throw 'todo';
+			throw new Error('Expected a valid number for the UUID length, but received NaN.');
 		}
 
 		while (result.length < outputLength) {