Skip to content

Commit beb9dc8

Browse files
committed
Fix pull request comments
Signed-off-by: Bryan Frimin <bryan@getprobo.com>
1 parent 14b5e24 commit beb9dc8

File tree

6 files changed

+10
-13
lines changed

6 files changed

+10
-13
lines changed

apps/console/src/pages/organizations/policies/EditPolicyView.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,14 @@ import {
99
} from "react-relay";
1010
import { Card, CardContent, CardHeader, CardTitle } from "@/components/ui/card";
1111
import { Button } from "@/components/ui/button";
12-
import { Input } from "@/components/ui/input";
1312
import { Textarea } from "@/components/ui/textarea";
1413
import { Label } from "@/components/ui/label";
1514
import { toast } from "@/hooks/use-toast";
1615
import { Suspense } from "react";
17-
import PeopleSelector from "@/components/PeopleSelector";
1816
import type { EditPolicyViewQuery } from "./__generated__/EditPolicyViewQuery.graphql";
1917
import type { EditPolicyViewMutation as EditPolicyViewMutationType } from "./__generated__/EditPolicyViewMutation.graphql";
2018
import { PageTemplate } from "@/components/PageTemplate";
2119
import { EditPolicyViewSkeleton } from "./EditPolicyPage";
22-
import { User } from "lucide-react";
2320

2421
const editPolicyViewQuery = graphql`
2522
query EditPolicyViewQuery($policyId: ID!, $organizationId: ID!, $policyVersionId: ID!) {

apps/console/src/pages/organizations/policies/PolicyListView.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,8 @@ import {
3838
DialogTitle,
3939
DialogDescription,
4040
} from "@/components/ui/dialog";
41-
import { Avatar } from "@/components/ui/avatar";
42-
import { cn } from "@/lib/utils";
4341
import PeopleSelector from "@/components/PeopleSelector";
4442
import type { PeopleSelector_organization$key } from "@/components/__generated__/PeopleSelector_organization.graphql";
45-
import { Input } from "@/components/ui/input";
4643
import { Textarea } from "@/components/ui/textarea";
4744

4845
const policyListViewQuery = graphql`
@@ -363,7 +360,7 @@ function CreatePolicyModal({
363360
className={`text-4xl leading-tight font-bold outline-none focus:outline-none ${!title ? 'text-gray-400' : 'text-black'}`}
364361
contentEditable
365362
suppressContentEditableWarning
366-
onBlur={(e) => setTitle(e.currentTarget.textContent || "")}
363+
onInput={(e) => setTitle(e.currentTarget.textContent || "")}
367364
style={{ WebkitTapHighlightColor: 'transparent' }}
368365
onClick={(e) => {
369366
if (!title) {

pkg/coredata/migrations/20250424T094500Z.sql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ SELECT
3333
p.tenant_id,
3434
p.id,
3535
1,
36-
'',
36+
p.content,
3737
'Initial version',
3838
p.owner_id,
3939
'DRAFT',
@@ -56,5 +56,5 @@ SET current_published_version = 1
5656
WHERE EXISTS (
5757
SELECT 1 FROM policy_versions pv
5858
WHERE pv.policy_id = p.id
59-
AND pv.status = 'published'
59+
AND pv.status = 'PUBLISHED'
6060
);

pkg/coredata/policy_version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ INSERT INTO policy_versions (
189189
"content": p.Content,
190190
"changelog": p.Changelog,
191191
"created_by": p.CreatedBy,
192-
"status": PolicyStatusDraft,
192+
"status": p.Status,
193193
"created_at": now,
194194
"updated_at": now,
195195
}

pkg/coredata/policy_version_signature_state.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ func (pvs *PolicyVersionSignatureState) UnmarshalText(data []byte) error {
4141
case PolicyVersionSignatureStateSigned.String():
4242
*pvs = PolicyVersionSignatureStateSigned
4343
default:
44-
return fmt.Errorf("invalid MesureState value: %q", val)
44+
return fmt.Errorf("invalid PolicyVersionSignatureState value: %q", val)
4545
}
4646

4747
return nil
@@ -55,6 +55,8 @@ func (pvs PolicyVersionSignatureState) String() string {
5555
val = "REQUESTED"
5656
case PolicyVersionSignatureStateSigned:
5757
val = "SIGNED"
58+
default:
59+
panic(fmt.Errorf("invalid PolicyVersionSignatureState value: %q", string(pvs)))
5860
}
5961

6062
return val
@@ -63,7 +65,7 @@ func (pvs PolicyVersionSignatureState) String() string {
6365
func (pvs *PolicyVersionSignatureState) Scan(value any) error {
6466
val, ok := value.(string)
6567
if !ok {
66-
return fmt.Errorf("invalid scan source for MesureState, expected string got %T", value)
68+
return fmt.Errorf("invalid scan source for PolicyVersionSignatureState, expected string got %T", value)
6769
}
6870

6971
return pvs.UnmarshalText([]byte(val))

pkg/probo/policy_service.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ func (s *PolicyService) Create(
136136
PolicyID: policyID,
137137
VersionNumber: 1,
138138
Content: req.Content,
139+
Status: coredata.PolicyStatusDraft,
139140
CreatedBy: req.CreatedBy,
140141
CreatedAt: now,
141142
UpdatedAt: now,
@@ -147,7 +148,7 @@ func (s *PolicyService) Create(
147148
return fmt.Errorf("cannot insert policy: %w", err)
148149
}
149150

150-
if err := policyVersion.Update(ctx, conn, s.svc.scope); err != nil {
151+
if err := policyVersion.Insert(ctx, conn, s.svc.scope); err != nil {
151152
return fmt.Errorf("cannot create policy version: %w", err)
152153
}
153154

0 commit comments

Comments
 (0)