Skip to content

Commit 03cac7e

Browse files
authored
Fix: backport security fix from v4.0.2 - don't expose Google OAuth client secret. (#2839)
1 parent defb3b9 commit 03cac7e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

redash/settings/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def all_settings():
5050

5151
GOOGLE_CLIENT_ID = os.environ.get("REDASH_GOOGLE_CLIENT_ID", "")
5252
GOOGLE_CLIENT_SECRET = os.environ.get("REDASH_GOOGLE_CLIENT_SECRET", "")
53-
GOOGLE_OAUTH_ENABLED = GOOGLE_CLIENT_ID and GOOGLE_CLIENT_SECRET
53+
GOOGLE_OAUTH_ENABLED = bool(GOOGLE_CLIENT_ID and GOOGLE_CLIENT_SECRET)
5454

5555
# Enables the use of an externally-provided and trusted remote user via an HTTP
5656
# header. The "user" must be an email address.

0 commit comments

Comments
 (0)