I am working on my first PR, the code works but the logo for the runner is not displayed

[zbalkan]

Hi all,

I am working on my PR for DuckDB runner. It works functionally but there's an issue with logo.

I put the image under redash/client/app/assets/images/db-logos, the permission and ownership is correct as well. I've been rebuilding the image but nothing changes. The Logo file does not end up in the image.

What can I do?

[yoshiokatsuneo]

@zbalkan

Thank you for your contribution !!

I think the filename of the logo need to be the lower case of the class name, like "duckdb.png" for the class "DuckDB", or you can customize the type name by defining "type" method.

[zbalkan]

Hi @yoshiokatsuneo,

I am using the path client/app/assets/images/db-logos/duckdb.png, so the name looks fine. But for some reason, I cannot make it work. try to investigate it. All I get is 404 Not found.

[yoshiokatsuneo]

@zbalkan
I think you need to build frontend by running "yarn build" so that the duckdb.png is copied to "client/dist/images/db-logos/duckdb.png".

[zbalkan]

I am under the assumption that make build included yarn build so never tried to run it separately. I should have checked and verified my assumption before asking here. Thanks.

[yoshiokatsuneo]

Actually, "make build" should be the synonym of the "yarn build" as far as I see Makefile...

[zbalkan]

Yep. I see that as well. But for some reason, it did not work. I recreated dev environment from scratch. I had to solve some indirect dependency issues in the local development environment. If I can finally get them solved, I can send the PR after testing properly.

[yoshiokatsuneo]

Great!