fix: address Warden findings and consolidate view formatter

- Forward start/end params for absolute date ranges (GGA-VPD)
- Guard against Infinity timestamps on empty spans (5RV-D34)
- Consolidate view formatter into formatTranscriptResult
- Fix tsc strict null check on span index lookup

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: sergical

src/commands/ai-conversations/list.ts

@@ -76,7 +76,7 @@ function formatListHuman(result: ConversationListResult): string {
 
 function jsonTransform(
   result: ConversationListResult,
-  fields?: string[],
+  fields?: string[]
 ): unknown {
   const items =
     fields && fields.length > 0
@@ -88,7 +88,9 @@ function jsonTransform(
     hasMore: result.hasMore,
     hasPrev: !!result.hasPrev,
   };
-  if (result.nextCursor) envelope.nextCursor = result.nextCursor;
+  if (result.nextCursor) {
+    envelope.nextCursor = result.nextCursor;
+  }
   return envelope;
 }
 
@@ -106,7 +108,7 @@ export const listCommand = buildListCommand("ai-conversations", {
   },
   output: {
     human: formatListHuman,
-    jsonTransform: jsonTransform,
+    jsonTransform,
     schema: ConversationListItemSchema,
   },
   parameters: {
@@ -148,20 +150,19 @@ export const listCommand = buildListCommand("ai-conversations", {
     const resolved = await resolveOrg({ org: target, cwd });
     if (!resolved) {
       throw new Error(
-        `Could not determine organization. Pass it explicitly: sentry ${COMMAND_NAME} <org>`,
+        `Could not determine organization. Pass it explicitly: sentry ${COMMAND_NAME} <org>`
       );
     }
     const org = resolved.org;
 
-    const contextKey = buildPaginationContextKey(
-      "ai-conversations",
-      org,
-      { q: flags.query, period: serializeTimeRange(flags.period) },
-    );
+    const contextKey = buildPaginationContextKey("ai-conversations", org, {
+      q: flags.query,
+      period: serializeTimeRange(flags.period),
+    });
     const { cursor, direction } = resolveCursor(
       flags.cursor,
       PAGINATION_KEY,
-      contextKey,
+      contextKey
     );
 
     const timeParams = timeRangeToApiParams(flags.period);
@@ -176,8 +177,8 @@ export const listCommand = buildListCommand("ai-conversations", {
           query: flags.query,
           limit: flags.limit,
           cursor,
-          statsPeriod: timeParams.statsPeriod,
-        }),
+          ...timeParams,
+        })
     );
 
     advancePaginationState(PAGINATION_KEY, contextKey, direction, nextCursor);

src/commands/ai-conversations/view.ts

@@ -9,7 +9,7 @@ import { getConversationSpans } from "../../lib/api/ai-conversations.js";
 import { buildCommand } from "../../lib/command.js";
 import {
   buildTranscriptResult,
-  formatTranscript,
+  formatTranscriptResult,
   type TranscriptResult,
 } from "../../lib/formatters/ai-conversations.js";
 import { CommandOutput } from "../../lib/formatters/output.js";
@@ -19,94 +19,12 @@ import {
   FRESH_FLAG,
 } from "../../lib/list-command.js";
 import { withProgress } from "../../lib/polling.js";
-import { resolveOrg } from "../../lib/resolve-target.js";
 
 type ViewFlags = {
   readonly json: boolean;
   readonly fresh: boolean;
 };
 
-function formatViewHuman(result: TranscriptResult): string {
-  if (result.spanCount === 0) {
-    return `No spans found for conversation ${result.conversationId} in the last 30 days.`;
-  }
-
-  const lines: string[] = [];
-  lines.push(`AI Conversation: ${result.conversationId}`);
-  lines.push("");
-  lines.push(`  Org:      ${result.org}`);
-  lines.push(`  Projects: ${result.projects.join(", ") || "—"}`);
-  lines.push(
-    `  Started:  ${new Date(result.startTimestamp * 1000).toISOString()}`,
-  );
-  lines.push(
-    `  Ended:    ${new Date(result.endTimestamp * 1000).toISOString()}`,
-  );
-  lines.push(`  Turns:    ${result.turns.length}`);
-  lines.push(`  Spans:    ${result.spanCount}`);
-  lines.push(`  Tokens:   ${result.totalTokens}`);
-  lines.push("");
-
-  for (const turn of result.turns) {
-    const meta = [
-      turn.model,
-      turn.agentName,
-      turn.totalTokens > 0 ? `${turn.totalTokens} tokens` : null,
-      turn.durationMs < 1000
-        ? `${turn.durationMs}ms`
-        : `${(turn.durationMs / 1000).toFixed(1)}s`,
-    ]
-      .filter(Boolean)
-      .join(" | ");
-
-    lines.push(
-      `── Turn ${turn.turn} — ${new Date(turn.started * 1000).toISOString()}`,
-    );
-    if (meta) lines.push(`   ${meta}`);
-    lines.push("");
-
-    if (turn.userContent) {
-      lines.push("   [user]");
-      const content =
-        turn.userContent.length > 600
-          ? `${turn.userContent.slice(0, 599)}…`
-          : turn.userContent;
-      for (const line of content.split("\n")) {
-        lines.push(`   ${line}`);
-      }
-      lines.push("");
-    }
-
-    if (turn.assistantContent) {
-      lines.push("   [assistant]");
-      const content =
-        turn.assistantContent.length > 600
-          ? `${turn.assistantContent.slice(0, 599)}…`
-          : turn.assistantContent;
-      for (const line of content.split("\n")) {
-        lines.push(`   ${line}`);
-      }
-      lines.push("");
-    }
-
-    if (turn.toolCalls.length > 0) {
-      lines.push("   [tools]");
-      for (const tc of turn.toolCalls) {
-        const dur =
-          tc.durationMs < 1000
-            ? `${tc.durationMs}ms`
-            : `${(tc.durationMs / 1000).toFixed(1)}s`;
-        const status =
-          tc.status && tc.status !== "ok" ? ` (${tc.status})` : "";
-        lines.push(`   • ${tc.name} — ${dur}${status}`);
-      }
-      lines.push("");
-    }
-  }
-
-  return lines.join("\n");
-}
-
 export const viewCommand = buildCommand({
   docs: {
     brief: "View an AI conversation transcript",
@@ -117,7 +35,7 @@ export const viewCommand = buildCommand({
       "  sentry ai-conversations view my-org conv-123 --json\n",
   },
   output: {
-    human: formatViewHuman,
+    human: formatTranscriptResult,
   },
   parameters: {
     positional: {
@@ -144,7 +62,7 @@ export const viewCommand = buildCommand({
     this: SentryContext,
     flags: ViewFlags,
     org: string,
-    conversationId: string,
+    conversationId: string
   ) {
     applyFreshFlag(flags);
 
@@ -153,7 +71,7 @@ export const viewCommand = buildCommand({
         message: "Fetching conversation spans...",
         json: flags.json,
       },
-      () => getConversationSpans(org, conversationId),
+      () => getConversationSpans(org, conversationId)
     );
 
     const result = buildTranscriptResult(conversationId, org, spans);

src/lib/api/ai-conversations.ts

@@ -6,10 +6,10 @@
  */
 
 import {
-  AIConversationSpanSchema,
-  ConversationListItemSchema,
   type AIConversationSpan,
+  AIConversationSpanSchema,
   type ConversationListItem,
+  ConversationListItemSchema,
 } from "../../types/ai-conversations.js";
 
 import { resolveOrgRegion } from "../region.js";
@@ -27,23 +27,39 @@ export async function listConversations(
     limit?: number;
     cursor?: string;
     statsPeriod?: string;
+    start?: string;
+    end?: string;
     project?: string;
-  } = {},
+  } = {}
 ): Promise<PaginatedResponse<ConversationListItem[]>> {
   const regionUrl = await resolveOrgRegion(orgSlug);
 
   const params: Record<string, string> = {
     per_page: String(options.limit ?? 10),
   };
-  if (options.statsPeriod) params.statsPeriod = options.statsPeriod;
-  if (options.cursor) params.cursor = options.cursor;
-  if (options.query) params.query = options.query;
-  if (options.project) params.project = options.project;
+  if (options.statsPeriod) {
+    params.statsPeriod = options.statsPeriod;
+  }
+  if (options.start) {
+    params.start = options.start;
+  }
+  if (options.end) {
+    params.end = options.end;
+  }
+  if (options.cursor) {
+    params.cursor = options.cursor;
+  }
+  if (options.query) {
+    params.query = options.query;
+  }
+  if (options.project) {
+    params.project = options.project;
+  }
 
   const { data, headers } = await apiRequestToRegion<unknown[]>(
     regionUrl,
     `/organizations/${orgSlug}/ai-conversations/`,
-    { params },
+    { params }
   );
 
   const items = data.map((item) => ConversationListItemSchema.parse(item));
@@ -59,32 +75,38 @@ export async function getConversationSpans(
     statsPeriod?: string;
     project?: string;
     perPage?: number;
-  } = {},
+  } = {}
 ): Promise<AIConversationSpan[]> {
   const regionUrl = await resolveOrgRegion(orgSlug);
 
   const params: Record<string, string> = {
     per_page: String(options.perPage ?? 1000),
     statsPeriod: options.statsPeriod ?? "30d",
   };
-  if (options.project) params.project = options.project;
+  if (options.project) {
+    params.project = options.project;
+  }
 
   const spans: AIConversationSpan[] = [];
   let cursor: string | undefined;
 
   for (let page = 0; page < 10; page++) {
-    if (cursor) params.cursor = cursor;
+    if (cursor) {
+      params.cursor = cursor;
+    }
 
     const { data, headers } = await apiRequestToRegion<unknown[]>(
       regionUrl,
       `/organizations/${orgSlug}/ai-conversations/${encodeURIComponent(conversationId)}/`,
-      { params },
+      { params }
     );
 
     spans.push(...data.map((s) => AIConversationSpanSchema.parse(s)));
     const parsed = parseLinkHeader(headers.get("link") ?? null);
     cursor = parsed.nextCursor;
-    if (!cursor) break;
+    if (!cursor) {
+      break;
+    }
   }
 
   return spans;