fix(github): Fix making github releases latest or not

Also includes #567

Author: mydea

src/targets/github.ts

@@ -111,7 +111,8 @@ export class GitHubTarget extends BaseTarget {
   public async createDraftRelease(
     version: string,
     revision: string,
-    changes?: Changeset
+    changes?: Changeset,
+    isLatest = true
   ): Promise<GitHubRelease> {
     const tag = versionToTag(version, this.githubConfig.tagPrefix);
     this.logger.info(`Git tag: "${tag}"`);
@@ -127,26 +128,6 @@ export class GitHubTarget extends BaseTarget {
       };
     }
 
-    let latestRelease: { tag_name: string } | undefined;
-    try {
-      latestRelease = (
-        await this.github.repos.getLatestRelease({
-          owner: this.githubConfig.owner,
-          repo: this.githubConfig.repo,
-        })
-      ).data;
-    } catch (error) {
-      // if the error is a 404 error, it means that no release exists yet
-      // all other errors should be rethrown
-      if (error.status !== 404) {
-        throw error;
-      }
-    }
-
-    const isLatest = isPreview
-      ? false
-      : isLatestRelease(latestRelease, version);
-
     const { data } = await this.github.repos.createRelease({
       draft: true,
       name: tag,
@@ -347,7 +328,7 @@ export class GitHubTarget extends BaseTarget {
    *
    * @param release Release object
    */
-  public async publishRelease(release: GitHubRelease) {
+  public async publishRelease(release: GitHubRelease, isLatest = true) {
     if (isDryRun()) {
       this.logger.info(`[dry-run] Not publishing the draft release`);
       return;
@@ -356,6 +337,7 @@ export class GitHubTarget extends BaseTarget {
     await this.github.repos.updateRelease({
       ...this.githubConfig,
       release_id: release.id,
+      make_latest: isLatest ? 'true' : 'false',
       draft: false,
     });
   }
@@ -418,10 +400,40 @@ export class GitHubTarget extends BaseTarget {
       }))
     );
 
+    let latestRelease: { tag_name: string } | undefined = undefined;
+    try {
+      latestRelease = (
+        await this.github.repos.getLatestRelease({
+          owner: this.githubConfig.owner,
+          repo: this.githubConfig.repo,
+        })
+      ).data;
+    } catch (error) {
+      // if the error is a 404 error, it means that no release exists yet
+      // all other errors should be rethrown
+      if (error.status !== 404) {
+        throw error;
+      }
+    }
+
+    const latestReleaseTag = latestRelease?.tag_name;
+    this.logger.info(
+      latestReleaseTag
+        ? `Previous release: ${latestReleaseTag}`
+        : 'No previous release found'
+    );
+
+    const isPreview =
+      this.githubConfig.previewReleases && isPreviewRelease(version);
+    const isLatest = isPreview
+      ? false
+      : isLatestRelease(latestRelease, version);
+
     const draftRelease = await this.createDraftRelease(
       version,
       revision,
-      changelog
+      changelog,
+      isLatest
     );
 
     await Promise.all(
@@ -430,7 +442,7 @@ export class GitHubTarget extends BaseTarget {
       )
     );
 
-    await this.publishRelease(draftRelease);
+    await this.publishRelease(draftRelease, isLatest);
   }
 }