Skip to content

Commit 4329cdb

Browse files
authored
fix(replay): Assigns Experimental View Renderer options in SentryReplayOptions init (#4988)
1 parent 455374d commit 4329cdb

File tree

3 files changed

+46
-0
lines changed

3 files changed

+46
-0
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66

77
- Slightly speed up adding breadcrumbs (#4984)
88

9+
### Fixes
10+
11+
- Fixes experimental Replay view renderer options initialisation (#4988)
12+
913
## 8.47.0
1014

1115
> [!Important]

Sources/Swift/Integrations/SessionReplay/SentryReplayOptions.swift

+2
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,8 @@ public class SentryReplayOptions: NSObject, SentryRedactOptions {
206206
self.onErrorSampleRate = onErrorSampleRate
207207
self.maskAllText = maskAllText
208208
self.maskAllImages = maskAllImages
209+
self.enableExperimentalViewRenderer = enableExperimentalViewRenderer
210+
self.enableFastViewRendering = enableFastViewRendering
209211
}
210212

211213
convenience init(dictionary: [String: Any]) {

Tests/SentryTests/Integrations/SessionReplay/SentryReplayOptionsTests.swift

+40
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,44 @@ class SentryReplayOptionsTests: XCTestCase {
173173
])
174174
XCTAssertTrue(options.maskAllImages)
175175
}
176+
177+
func testInitFromDictEnableExperimentalViewRendererWithBool() {
178+
let options = SentryReplayOptions(dictionary: [
179+
"enableExperimentalViewRenderer": true
180+
])
181+
XCTAssertTrue(options.enableExperimentalViewRenderer)
182+
183+
let options2 = SentryReplayOptions(dictionary: [
184+
"enableExperimentalViewRenderer": false
185+
])
186+
XCTAssertFalse(options2.enableExperimentalViewRenderer)
187+
}
188+
189+
func testInitFromDictEnableExperimentalViewRendererWithString() {
190+
let options = SentryReplayOptions(dictionary: [
191+
"enableExperimentalViewRenderer": "invalid_value"
192+
])
193+
XCTAssertFalse(options.enableExperimentalViewRenderer)
194+
}
195+
196+
func testInitFromDictEnableFastViewRenderingWithBool() {
197+
let options = SentryReplayOptions(dictionary: [
198+
"enableFastViewRendering": true
199+
])
200+
XCTAssertTrue(options.enableFastViewRendering)
201+
202+
let options2 = SentryReplayOptions(dictionary: [
203+
"enableFastViewRendering": false
204+
])
205+
XCTAssertFalse(options2.enableFastViewRendering)
206+
}
207+
208+
func testInitFromDictEnableFastViewRenderingWithString() {
209+
let options = SentryReplayOptions(dictionary: [
210+
"enableFastViewRendering": "invalid_value"
211+
])
212+
XCTAssertFalse(options.enableFastViewRendering)
213+
}
176214

177215
func testInitFromDictQualityWithString() {
178216
let options = SentryReplayOptions(dictionary: [
@@ -217,6 +255,8 @@ class SentryReplayOptionsTests: XCTestCase {
217255
XCTAssertEqual(options.onErrorSampleRate, 0.8)
218256
XCTAssertFalse(options.maskAllText)
219257
XCTAssertTrue(options.maskAllImages)
258+
XCTAssertFalse(options.enableExperimentalViewRenderer)
259+
XCTAssertFalse(options.enableFastViewRendering)
220260
XCTAssertEqual(options.maskedViewClasses.count, 1)
221261
XCTAssertEqual(ObjectIdentifier(options.maskedViewClasses.first!), ObjectIdentifier(NSString.self))
222262
XCTAssertEqual(options.unmaskedViewClasses.count, 1)

0 commit comments

Comments
 (0)