Merge pull request #91 from getsentry/feature/reverse-frames

Reverse frames in stacktrace, Remove in_app from stacktrace

Author: HazAT

SentrySwift.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name         = "SentrySwift"
-  s.version      = "1.1.0"
+  s.version      = "1.2.0"
   s.summary      = "Swift client for Sentry"
   s.homepage     = "https://github.com/getsentry/sentry-swift"
   s.license      = "mit"

SentrySwift/Info.plist

@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.1.0</string>
+	<string>1.2.0</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>

SentrySwiftTests/SentrySwiftCrashTests.swift

@@ -160,11 +160,9 @@ class SentrySwiftCrashTests: XCTestCase {
 		XCTAssertEqual(thread0Frames[0].instructionAddress, "0x3157e63d")
 		XCTAssertEqual(thread0Frames[0].symbolAddress, "0x3157e5dc")
 		XCTAssertEqual(thread0Frames[0].imageAddress, "0x314e0000")
-		XCTAssertEqual(thread0Frames[0].inApp, false)
 		XCTAssertEqual(thread0Frames[1].instructionAddress, "0x35099c5d")
 		XCTAssertEqual(thread0Frames[1].symbolAddress, "0x35099c44")
 		XCTAssertEqual(thread0Frames[1].imageAddress, "0x35095000")
-		XCTAssertEqual(thread0Frames[1].inApp, true)
 
 		// Thread 1
 		let thread1 = threads[1]

Sources/Sentry.swift

@@ -65,7 +65,7 @@ internal enum SentryError: Error {
 	// MARK: - Enums
 
 	internal struct Info {
-		static let version: String = "1.1.0"
+		static let version: String = "1.2.0"
 		static let sentryVersion: Int = 7
 	}
 

Sources/Stacktrace.swift

@@ -19,7 +19,7 @@ import Foundation
         }
 
         let frames = (appleCrashTreadBacktraceDict["contents"] as? [[String: AnyObject]])?
-            .flatMap({Frame(appleCrashFrameDict: $0, binaryImages: binaryImages)})
+            .flatMap({ Frame(appleCrashFrameDict: $0, binaryImages: binaryImages) })
         self.init(frames: frames)
 
     }
@@ -33,8 +33,13 @@ import Foundation
 extension Stacktrace: EventSerializable {
     internal typealias SerializedType = SerializedTypeDictionary
     internal var serialized: SerializedType {
+        #if swift(>=3.0)
         return [:]
-            .set("frames", value: frames.map({$0.serialized}))
+            .set("frames", value: frames.reversed().map({ $0.serialized }))
+        #else
+        return [:]
+            .set("frames", value: frames.reverse().map({ $0.serialized }))
+        #endif
     }
 }
 
@@ -50,7 +55,6 @@ extension Stacktrace: EventSerializable {
     public var platform: String?
     public var instructionAddress: String?
     public var symbolAddress: String?
-    public var inApp: Bool?
 
     var fileName: String? {
         guard let file = file else { return nil }
@@ -85,12 +89,6 @@ extension Stacktrace: EventSerializable {
             self.init()
 
             self.function = frameDict["symbol_name"] as? String
-            
-            #if swift(>=3.0)
-                self.inApp = binaryImage.name?.contains("/Bundle/Application/") ?? false
-            #else
-                self.inApp = binaryImage.name?.containsString("/Bundle/Application/") ?? false
-            #endif
             self.package = binaryImage.name
 
             self.imageAddress = BinaryImage.getHexAddress(binaryImage.imageAddress)
@@ -117,7 +115,6 @@ extension Frame: EventSerializable {
         attributes.append(("image_addr", imageAddress))
         attributes.append(("instruction_addr", instructionAddress))
         attributes.append(("symbol_addr", symbolAddress))
-        attributes.append(("in_app", inApp))
 
         return convertAttributes(attributes)
     }