fix: use a static const to define array size (#4917)

Author: armcknight

Sources/SentryCrash/Recording/Tools/SentryCrashMachineContext.c

@@ -91,12 +91,6 @@ getThreadList(SentryCrashMachineContext *context)
     return true;
 }
 
-int
-sentrycrashmc_contextSize(void)
-{
-    return sizeof(SentryCrashMachineContext);
-}
-
 SentryCrashThread
 sentrycrashmc_getThreadFromContext(const SentryCrashMachineContext *const context)
 {

Sources/SentryCrash/Recording/Tools/SentryCrashMachineContext.h

@@ -28,6 +28,7 @@
 #ifndef HDR_SentryCrashMachineContext_h
 #define HDR_SentryCrashMachineContext_h
 
+#include "SentryCrashMachineContext_Apple.h"
 #include "SentryCrashThread.h"
 #include <mach/mach.h>
 #include <stdbool.h>
@@ -64,16 +65,12 @@ void sentrycrashmc_resumeEnvironment(thread_act_array_t threads, mach_msg_type_n
  * @param NAME The C identifier to give the pointer.
  */
 #define SentryCrashMC_NEW_CONTEXT(NAME)                                                            \
-    char sentrycrashmc_##NAME##_storage[sentrycrashmc_contextSize()];                              \
+    char sentrycrashmc_##NAME##_storage[sentrycrashmc_contextSize];                                \
     struct SentryCrashMachineContext *NAME                                                         \
         = (struct SentryCrashMachineContext *)sentrycrashmc_##NAME##_storage
 
 struct SentryCrashMachineContext;
 
-/** Get the internal size of a machine context.
- */
-int sentrycrashmc_contextSize(void);
-
 /** Fill in a machine context from a thread.
  *
  * @param thread The thread to get information from.

Sources/SentryCrash/Recording/Tools/SentryCrashMachineContext_Apple.h

@@ -34,6 +34,7 @@ extern "C" {
 
 #include <mach/mach_types.h>
 #include <stdbool.h>
+#include <stddef.h>
 #include <sys/ucontext.h>
 
 #ifdef __arm64__
@@ -53,6 +54,8 @@ typedef struct SentryCrashMachineContext {
     STRUCT_MCONTEXT_L machineContext;
 } SentryCrashMachineContext;
 
+static const size_t sentrycrashmc_contextSize = sizeof(SentryCrashMachineContext);
+
 #ifdef __cplusplus
 }
 #endif