Skip to content

set upload_sourcemaps to true by default #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

set upload_sourcemaps to true by default #313

wants to merge 2 commits into from
+15 −5

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Mar 25, 2025 •
edited
Loading

📜 Description

set upload_sourcemaps to true by default

💡 Motivation and Context

Closes #311

💚 How did you test it?

Updated unit tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@denrase denrase marked this pull request as ready for review March 25, 2025 09:49
@buenaflor
Copy link
Contributor

@denrase I'm not sure if we can release this in a non-major, let's talk about this in the sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@buenaflor buenaflor Awaiting requested review from buenaflor buenaflor is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set upload_sourcemaps to true by default
2 participants
@denrase @buenaflor