Generate AotHelper properties at compile time

A couple of different options

# Use built in attributes

The [RuntimeFeature.IsDynamicCodeSupported Property](https://learn.microsoft.com/en-us/dotnet/api/system.runtime.compilerservices.runtimefeature.isdynamiccodesupported?view=net-8.0) looks like it might do what we want in many cases (I think we're using [`AotHelper.IsNativeAot`](https://github.com/getsentry/sentry-dotnet/blob/27ede88985fcc92ce2f7f8ae53ba11cfd805b2f5/src/Sentry/Internal/AotHelper.cs#L3-L20) where we should probably be checking for Trimming compatibility instead in some cases). Need to do a search for uses of `AotHelper.IsNativeAot` and a bit of a review of these. 

# Generate these at compile time

For this AotHelper, instead of:

https://github.com/getsentry/sentry-dotnet/blob/217c11cea611a5f26e4a1abfbb7df37f34695722/src/Sentry/Internal/AotHelper.cs#L18-L19

Could we instead write an attribute at compile time? I imagine it's a lot cheaper (worth measuring) than trying to get a stack trace on a static constructor:

Something like this:
https://github.com/getsentry/sentry-dotnet/blob/217c11cea611a5f26e4a1abfbb7df37f34695722/src/Sentry/buildTransitive/Sentry.targets#L8-L29


Here's a PR that added writing the attribute at build time as a reference: https://github.com/getsentry/sentry-dotnet/pull/1739

_Originally posted by @bruno-garcia in https://github.com/getsentry/sentry-dotnet/pull/2920#discussion_r1409457272_
            

# References

- More info available here: https://devblogs.microsoft.com/dotnet/creating-aot-compatible-libraries/

	<Target Name="WriteSentryAttributes"
	Condition="$(Language) == 'VB' or $(Language) == 'C#' or $(Language) == 'F#'"
	BeforeTargets="BeforeCompile;CoreCompile"
	Inputs="$(MSBuildAllProjects)"
	Outputs="$(IntermediateOutputPath)$(SentryAttributesFile)">
	<PropertyGroup>
	<SentryAttributesFilePath>$(IntermediateOutputPath)$(SentryAttributesFile)</SentryAttributesFilePath>
	</PropertyGroup>
	<ItemGroup>
	<SentryAttributes Include="System.Reflection.AssemblyMetadata">
	<_Parameter1>Sentry.ProjectDirectory</_Parameter1>
	<_Parameter2>$(ProjectDir)</_Parameter2>
	</SentryAttributes>
	<!-- Ensure not part of Compile, as a workaround for https://github.com/dotnet/sdk/issues/114 -->
	<Compile Remove="$(SentryAttributesFilePath)" />
	</ItemGroup>
	<WriteCodeFragment AssemblyAttributes="@(SentryAttributes)" Language="$(Language)" OutputFile="$(SentryAttributesFilePath)">
	<Output Condition="$(Language) != 'F#'" TaskParameter="OutputFile" ItemName="Compile" />
	<Output Condition="$(Language) == 'F#'" TaskParameter="OutputFile" ItemName="CompileBefore" />
	<Output TaskParameter="OutputFile" ItemName="FileWrites" />
	</WriteCodeFragment>
	</Target>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate AotHelper properties at compile time #2927

Use built in attributes

Generate these at compile time

References

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	var stackTrace = new StackTrace(false);
	IsNativeAot = stackTrace.GetFrame(0)?.GetMethod() is null;

Generate AotHelper properties at compile time #2927

Description

Use built in attributes

Generate these at compile time

References

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions