Skip to content

Conversation

@eni4sure
Copy link

Fixes #536

@lforst
Copy link

lforst commented Mar 12, 2025

Hi, unfortunately we cannot merge this PR as-is because it will actually change whether the release management plugin is added or not, which controls a bunch of other things too. We would need to be a little bit smarter about this.

@eni4sure
Copy link
Author

@lforst That makes sense. I pushed an update to explicitly check if both release.create and release.finalize is set to false to disable releases. That should avoid any unintended changes.

@Lms24
Copy link
Member

Lms24 commented May 21, 2025

Hey @eni4sure 👋 Really sorry that this PR went unnoticed for such a long time. We did quite a few refactors in the meantime. Are you still up to get this PR over the finish line? If so, could you rebase it to the latest main commit and re-check if the fix still applies correctly? If not, that's of course fine, too. Again, sorry for the delayed response!

heads-up: I'm only assigning myself to this PR so that I don't loose track of it. Doesn't mean I'm taking over but just waiting for your response :)

@Lms24 Lms24 self-requested a review May 21, 2025 07:57
@Lms24 Lms24 self-assigned this May 21, 2025
@eni4sure
Copy link
Author

eni4sure commented May 26, 2025

hey @Lms24, haven't tested but would close for now.

@eni4sure eni4sure closed this May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dont log warnings when certain features are disabled

3 participants