Skip to content

Vendor @opentelemetry/instrumentation-undici #20165

@linear-code

Description

@linear-code

Vendor in @opentelemetry/instrumentation-undici into the SDK.

Follow this process:

  1. Vendor the instrumentation as-is, with as little changes as possible.
  2. Make sure each vendored file contains the licence on top.
  3. Generally follow this folder layout:
    • src/integrations/tracing/undici/index.ts for the Sentry integration
    • src/integrations/tracing/undici/vendored/xxx for vendored files
  4. Vendor in sub-dependencies of the instrumentation as much as possible, including types. Avoid adding runtime dependencies to the SDK.
  5. Disable eslint for the files if necessary in the initial PR, and fix those in a follow-up.
  6. In a follow-up PR, adapt or streamline the instrumentation to SDK needs, removing parts that are not needed.
  7. Finally, rewrite integrations to not depend on @opentelemetry/instrumentation but implement an internal base.

Metadata

Metadata

Assignees

Labels

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions