Skip to content

Deprecate instrumentD1WithSentry and instrument via ENV variables #20862

@JPeer264

Description

@JPeer264

Problem Statement

As of now instrumentD1WithSentry needs to be used every time when env.DB is used. This can now be archived via instrumentEnv.

Also increase support, as now we only instrument prepare statements and nothing else

Solution Brainstorm

We need to be careful about double instrumentation. When enabling D1 support by default via env instrumentation and a user has their D1 manually instrumented, then we shouldn't double wrap. Maybe ensureInstrumented can help out

Additional Context

batch, exec and withSession are not instrumented. dump seems to be deprecated and is only valid for v1 databases, where we anyways don't have support

Priority

React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it.

Metadata

Metadata

Assignees

No one assigned
    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions