-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More lenient handling of empty Maven modules #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, I think this makes sense! @adinauer wdyt?
Thanks for the PR @nikita2206 I'm still occupied with preparing another release of the Java SDK but am planning to take a look at this PR soon - sorry for the wait. |
Thank you all! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR
#skip-changelog ## 📜 Description add integration test for PR #103 ## 💡 Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## 💚 How did you test it? ## 📝 Checklist <!--- Put an `x` in the boxes that apply --> - [ ] I reviewed the submitted code - [ ] I added tests to verify the changes - [ ] I updated the docs if needed - [ ] No breaking changes ## 🔮 Next steps
📜 Description
Maven allows for empty modules to exist, e.g. you can have a Maven module without any Java sources in it.
This is especially common in multi-module projects, where the root module has no sources at all, but only contains children modules; thus the root module does not contain the
src/main/java
directory.Our use case
Maven supports inheritance of plugins, that is in multi-module project you can declare a plugin (using
<plugins><plugin> .... </plugins>
) in the rootpom.xml
and then this definition will be inherited by all children modules. This would allow us to declare the Sentry plugin only once in the rootpom.xml
, and have it be inherited in all children.However, this does not work, because our root
pom.xml
is an empty module without Java sources, and currently Sentry plugin fails in these circumstances.💡 Motivation and Context
Allow more convenient use of Sentry plugin in multi-module Maven deployments.
💚 How did you test it?
🔧 Manually tested -> works as expected with a multi-module projects
📝 Checklist
🔮 Next steps