-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect SDK dependency version mismatches #126
base: main
Are you sure you want to change the base?
Conversation
src/test/java/io/sentry/integration/ValidateSdkDependencyVersionsTestIT.kt
Outdated
Show resolved
Hide resolved
Need to check what happens with the BOM as well |
Added some tests scenarios where the BOM is used as well. |
src/test/java/io/sentry/integration/ValidateSdkDependencyVersionsTestIT.kt
Outdated
Show resolved
Hide resolved
src/test/java/io/sentry/integration/ValidateSdkDependencyVersionsTestIT.kt
Show resolved
Hide resolved
src/test/java/io/sentry/integration/ValidateSdkDependencyVersionsTestIT.kt
Show resolved
Hide resolved
src/test/java/io/sentry/integration/ValidateSdkDependencyVersionsTestIT.kt
Show resolved
Hide resolved
@lcian afaik there is no simple way around setting |
That's a shame, would've been great to have this run automatically without customers needing to enable it. |
📜 Description
Adds a new task
validateSdkDependencyVersions
that checks for dependencies in theio.sentry
group (except for the plugin itself and the core SDKio.sentry:sentry
, as an explicit dependency on the core SDK module could be valid if the intention is to override the default version used by the plugin) and validates if they have consistent versions.Currently, customers would need to add
to their
pom.xml
to enable running this new task.I need to investigate on how to make it run automatically by default.
💡 Motivation and Context
Closes #123
💚 How did you test it?
I have tested different scenarios manually with the example project included in this repo.
I have also added integration tests, but it seems that they are not running this new task, even when explicitly specifying it as an execution goal.
📝 Checklist
🔮 Next steps
validate
phase (not possible)