http_ssl_verify_peer sets CURLOPT_SSL_VERIFYPEER correctly (#1686)

tanenbaum · cleptric · web-flow · commit 40ddd184692d · 2024-01-22T12:04:14.000Z
Co-authored-by: Michi Hoffmann &lt;cleptric@users.noreply.github.com&gt;
diff --git a/src/HttpClient/HttpClient.php b/src/HttpClient/HttpClient.php
@@ -74,8 +74,8 @@ public function sendRequest(Request $request, Options $options): Response
         curl_setopt($curlHandle, \CURLOPT_HTTP_VERSION, \CURL_HTTP_VERSION_1_1);
 
         $httpSslVerifyPeer = $options->getHttpSslVerifyPeer();
-        if ($httpSslVerifyPeer) {
-            curl_setopt($curlHandle, \CURLOPT_SSL_VERIFYPEER, true);
+        if (!$httpSslVerifyPeer) {
+            curl_setopt($curlHandle, \CURLOPT_SSL_VERIFYPEER, false);
         }
 
         $httpProxy = $options->getHttpProxy();

Original file line number	Diff line number	Diff line change
`@@ -74,8 +74,8 @@ public function sendRequest(Request $request, Options $options): Response`
`74`	`74`	`curl_setopt($curlHandle, \CURLOPT_HTTP_VERSION, \CURL_HTTP_VERSION_1_1);`
`75`	`75`
`76`	`76`	`$httpSslVerifyPeer = $options->getHttpSslVerifyPeer();`
`77`		`- if ($httpSslVerifyPeer) {`
`78`		`- curl_setopt($curlHandle, \CURLOPT_SSL_VERIFYPEER, true);`
	`77`	`+ if (!$httpSslVerifyPeer) {`
	`78`	`+ curl_setopt($curlHandle, \CURLOPT_SSL_VERIFYPEER, false);`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`$httpProxy = $options->getHttpProxy();`