Skip to content

Commit 5d32418

Browse files
committed
feat(trace-item-values): Add counts to response
- This adds counts to the response/orders by it so we get the most common values and know by how much
1 parent a49af12 commit 5d32418

3 files changed

Lines changed: 4 additions & 1 deletion

File tree

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

proto/sentry_protos/snuba/v1/endpoint_trace_item_attributes.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ message TraceItemAttributeValuesRequest {
9191
message TraceItemAttributeValuesResponse {
9292
// all the values that matched the criteria specified in the request
9393
repeated string values = 1;
94+
repeated int64 counts = 3;
9495

9596
// page token for the next page of results
9697
PageToken page_token = 6;

rust/src/sentry_protos.snuba.v1.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1738,6 +1738,8 @@ pub struct TraceItemAttributeValuesResponse {
17381738
/// all the values that matched the criteria specified in the request
17391739
#[prost(string, repeated, tag = "1")]
17401740
pub values: ::prost::alloc::vec::Vec<::prost::alloc::string::String>,
1741+
#[prost(int64, repeated, tag = "3")]
1742+
pub counts: ::prost::alloc::vec::Vec<i64>,
17411743
/// page token for the next page of results
17421744
#[prost(message, optional, tag = "6")]
17431745
pub page_token: ::core::option::Option<PageToken>,

0 commit comments

Comments
 (0)