Skip to content

Commit f23716d

Browse files
author
Kyle Mumma
authored
feat: default value for formulas (#119)
* init * init * imporve comment * sgdijsdlgj
1 parent 26ecba6 commit f23716d

3 files changed

Lines changed: 13 additions & 0 deletions

File tree

proto/sentry_protos/snuba/v1/endpoint_time_series.proto

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,12 @@ message Expression {
6565
Op op = 1;
6666
Expression left = 2;
6767
Expression right = 3;
68+
// optional, if the formula evalutates to null this value is returned
69+
// formula can evaluate to null if an attribute is missing for example
70+
oneof default_value {
71+
double default_value_double = 4;
72+
int64 default_value_int64 = 5;
73+
}
6874
}
6975
}
7076

proto/sentry_protos/snuba/v1/endpoint_trace_item_table.proto

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,12 @@ message Column {
9797
Op op = 1;
9898
Column left = 2;
9999
Column right = 3;
100+
// optional, if the formula evalutates to null this value is returned
101+
// formula can evaluate to null if an attribute is missing for example
102+
oneof default_value {
103+
double default_value_double = 4;
104+
int64 default_value_int64 = 5;
105+
}
100106
}
101107
}
102108

py/tests/test_snuba_v1.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ def test_example_time_series():
130130
),
131131
label="p90",
132132
),
133+
default_value_double=1.0,
133134
),
134135
label="p50 / p90"
135136
),

0 commit comments

Comments
 (0)