Allow logger to be a service reference

Author: stayallive

src/DependencyInjection/SentryExtension.php

@@ -94,6 +94,10 @@ private function registerConfiguration(ContainerBuilder $container, array $confi
             });
         }
 
+        if (isset($options['logger'])) {
+            $options['logger'] = new Reference($options['logger']);
+        }
+
         if (isset($options['traces_sampler'])) {
             $options['traces_sampler'] = new Reference($options['traces_sampler']);
         }

tests/DependencyInjection/Fixtures/php/full.php

@@ -21,7 +21,7 @@
         'attach_metric_code_locations' => true,
         'context_lines' => 0,
         'environment' => 'development',
-        'logger' => 'php',
+        'logger' => Sentry\Logger\DebugStdOutLogger::class,
         'spotlight' => true,
         'spotlight_url' => 'http://localhost:8969',
         'release' => '4.0.x-dev',

tests/DependencyInjection/Fixtures/xml/full.xml

@@ -20,7 +20,7 @@
                         attach-metric-code-locations="true"
                         context-lines="0"
                         environment="development"
-                        logger="php"
+                        logger="Sentry\Logger\DebugStdOutLogger"
                         spotlight="true"
                         spotlight-url="http://localhost:8969"
                         release="4.0.x-dev"

tests/DependencyInjection/Fixtures/yml/full.yml

@@ -16,7 +16,7 @@ sentry:
         attach_metric_code_locations: true
         context_lines: 0
         environment: development
-        logger: php
+        logger: Sentry\Logger\DebugStdOutLogger
         spotlight: true
         spotlight_url: http://localhost:8969
         release: 4.0.x-dev

tests/DependencyInjection/SentryExtensionTest.php

@@ -4,6 +4,7 @@
 
 namespace Sentry\SentryBundle\Tests\DependencyInjection;
 
+use Sentry\Logger\DebugStdOutLogger;
 use Doctrine\Bundle\DoctrineBundle\DoctrineBundle;
 use Jean85\PrettyVersions;
 use PHPUnit\Framework\TestCase;
@@ -211,7 +212,7 @@ public function testClientIsCreatedFromOptions(): void
             'attach_metric_code_locations' => true,
             'context_lines' => 0,
             'environment' => 'development',
-            'logger' => 'php',
+            'logger' => new Reference(DebugStdOutLogger::class),
             'spotlight' => true,
             'spotlight_url' => 'http://localhost:8969',
             'release' => '4.0.x-dev',