Fix/parsing logging (#1992)

Author: bitsandfoxes

src/Sentry.Unity/Integrations/UnityErrorLogException.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
+using Sentry.Extensibility;
 using Sentry.Protocol;
 using UnityEngine;
 
@@ -20,18 +21,14 @@ internal class UnityErrorLogException : Exception
         private readonly string _logStackTrace = string.Empty;
 
         private readonly SentryOptions? _options;
+        private readonly IDiagnosticLogger? _logger;
 
         public UnityErrorLogException(string logString, string logStackTrace, SentryOptions? options)
         {
             _logString = logString;
             _logStackTrace = logStackTrace;
             _options = options;
-        }
-
-        internal UnityErrorLogException(string logString, string logStackTrace)
-        {
-            _logString = logString;
-            _logStackTrace = logStackTrace;
+            _logger = _options?.DiagnosticLogger;
         }
 
         internal UnityErrorLogException() : base() { }
@@ -42,6 +39,8 @@ private UnityErrorLogException(string message, Exception innerException) : base(
 
         public SentryException ToSentryException()
         {
+            _logger?.LogDebug("Creating SentryException out of synthetic ErrorLogException");
+
             var frames = ParseStackTrace(_logStackTrace);
             frames.Reverse();
 
@@ -80,7 +79,7 @@ private List<SentryStackFrame> ParseStackTrace(string stackTrace)
                     continue;
                 }
 
-                var frame = ParseStackFrame(item);
+                var frame = ParseStackFrame(item, _logger);
                 if (_options is not null)
                 {
                     frame.ConfigureAppFrame(_options);
@@ -91,7 +90,7 @@ private List<SentryStackFrame> ParseStackTrace(string stackTrace)
             return frames;
         }
 
-        private static SentryStackFrame ParseStackFrame(string stackFrameLine)
+        private static SentryStackFrame ParseStackFrame(string stackFrameLine, IDiagnosticLogger? logger = null)
         {
             var closingParenthesis = stackFrameLine.IndexOf(')');
             if (closingParenthesis == -1)
@@ -121,8 +120,10 @@ private static SentryStackFrame ParseStackFrame(string stackFrameLine)
                     LineNumber = lineNo == -1 ? null : lineNo
                 };
             }
-            catch (Exception)
+            catch (Exception e)
             {
+                logger?.LogError(e, "Failed to parse the stack frame line {0}", stackFrameLine);
+
                 // Suppress any errors while parsing and fall back to a basic stackframe
                 return CreateBasicStackFrame(stackFrameLine);
             }