fix(dynamic-sampling):remove deleted projects from rebalancing #85443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
shellmayr
commented
Feb 19, 2025
shellmayr
commented
- Closes https://github.com/getsentry/projects/issues/674
github-actions
bot
added
the
Scope: Backend
shellmayr
commented
Feb 19, 2025
Comment on lines
+298
to
+302
| project_ids = list( | ||
| Project.objects.filter(organization_id__in=org_ids, status=ObjectStatus.ACTIVE).values_list( | ||
| "id", flat=True | ||
| ) | ||
| ) |
There was a problem hiding this comment.
This should be limited to 100 orgs, but can still be quite a large qeury (and the list of projects will be comparably large as well). Unsure if we need a faster / more efficient approach here
There was a problem hiding this comment.
True, but it looks to me that there is not much it can be done inside of this function to optimize it. If this turns out to be too slow, we can lower the limit to do the filtering for less orgs
vgrozdanic
approved these changes
Feb 19, 2025
jan-auer
approved these changes
Feb 20, 2025
shellmayr
deleted the
shellmayr/fix/remove-deleted-projects-from-rebalancing
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.