Skip to content

native: Conditionally use source server information #1945

@loewenheim

Description

@loewenheim

With #1943, Symbolicator gained support for source server information in symcaches. This source server information is supposed to be used conditionally to rewrite a native frame's abs_path/filename and set the revision field.

Whether this information should be used is controlled from the Sentry side by sending a flag apply_srcsrv with the symbolication request to Symbolicator, see getsentry/sentry#114839.

To implement this:

  1. Add an optional revision field to native frames.
  2. Pass the apply_srcsrv flag through from the request to the symbolicate_native_frame function.
  3. Set the abs_path/filename from source server information in the symcache or as it currently works, depending on the value of the flag.
  4. Set the revision from source server information depending on the value of the flag.

Metadata

Metadata

Labels

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions