This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Add 'Channel opening/closing' message while waiting tx confirmations … #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louneskmt
previously approved these changes
Jan 13, 2021
louneskmt
reviewed
Jan 13, 2021
src/components/BitcoinWallet.vue
Outdated
Comment on lines
183
to
189
| <span | ||
| v-if=" | ||
| tx.description === 'Lightning Wallet' && | ||
| tx.type === 'outgoing' | ||
| tx.type === 'outgoing' && | ||
| tx.confirmations === 0 | ||
| " | ||
| >• Channel opening</span | ||
| > | ||
| <span | ||
| v-else-if=" | ||
| tx.description === 'Lightning Wallet' && | ||
| tx.type === 'outgoing' && | ||
| tx.confirmations > 0 | ||
| " | ||
| >• Channel open</span | ||
| > |
There was a problem hiding this comment.
Suggested change
| <span | |
| v-if=" | |
| tx.description === 'Lightning Wallet' && | |
| tx.type === 'outgoing' | |
| tx.type === 'outgoing' && | |
| tx.confirmations === 0 | |
| " | |
| >• Channel opening</span | |
| > | |
| <span | |
| v-else-if=" | |
| tx.description === 'Lightning Wallet' && | |
| tx.type === 'outgoing' && | |
| tx.confirmations > 0 | |
| " | |
| >• Channel open</span | |
| > | |
| <span | |
| v-if=" | |
| tx.description === 'Lightning Wallet' && | |
| tx.type === 'outgoing' | |
| " | |
| >• {{ tx.confirmations === 0 ? "Channel opening" : "Channel open" }}</span | |
| > |
Maybe you can have only one span and change the text depending on the confirmation condition instead of having two identical span?
There was a problem hiding this comment.
Yeah totally, my bad I've done it to fast, I will update it and do the same for closing
|
Done 😄 |
louneskmt
approved these changes
Jan 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolve #274