Merge pull request #6 from getyoti/release-1.0.1

Release 1.0.1

Author: MrBurtyyy

yoti_python_sandbox/client.py

@@ -62,7 +62,8 @@ def setup_sharing_profile(self, request_token):
 
         response_payload = signed_request.execute()
         if response_payload.status_code < 200 or response_payload.status_code >= 300:
-            raise SandboxException("Error making request to sandbox service: " + response_payload.status_code, response_payload)
+            raise SandboxException("Error making request to sandbox service: "
+                                   + str(response_payload.status_code), response_payload)
 
         parsed = json.loads(response_payload.text)
         return YotiTokenResponse(parsed["token"])

yoti_python_sandbox/tests/mocks.py

@@ -0,0 +1,10 @@
+from yoti_python_sdk.http import YotiResponse
+
+
+class MockResponse(YotiResponse):
+    def __init__(self, status_code, text):
+        super(MockResponse, self).__init__(status_code, text)
+
+
+def mocked_request_failed_sandbox_token():
+    return MockResponse(500, "Org not found")

yoti_python_sandbox/tests/test_sandbox_client.py

@@ -2,11 +2,13 @@
 from yoti_python_sandbox.tests.conftest import PEM_FILE_PATH
 from yoti_python_sandbox.token import YotiTokenRequest
 from yoti_python_sandbox.token import YotiTokenResponse
+from .mocks import mocked_request_failed_sandbox_token
+from ..sandbox_exception import SandboxException
 
 try:
-    from unittest.mock import patch
+    from unittest import mock
 except ImportError:
-    from mock import patch
+    import mock
 
 import pytest
 
@@ -36,7 +38,7 @@ def test_builder_should_build_client():
     assert isinstance(client, SandboxClient)
 
 
-@patch("yoti_python_sandbox.client.SandboxClient")
+@mock.patch("yoti_python_sandbox.client.SandboxClient")
 def test_client_should_return_token_from_sandbox(sandbox_client_mock):
     sandbox_client_mock.setup_profile_share.return_value = YotiTokenResponse(
         "some-token"
@@ -48,3 +50,23 @@ def test_client_should_return_token_from_sandbox(sandbox_client_mock):
     response = sandbox_client_mock.setup_profile_share(token_request)
 
     assert response.token == "some-token"
+
+
+@mock.patch("yoti_python_sdk.http.SignedRequest.execute", side_effect=mocked_request_failed_sandbox_token)
+def test_client_should_bubble_sandbox_exception(_):
+    client = (
+        SandboxClient.builder()
+            .for_application("some_app")
+            .with_pem_file(PEM_FILE_PATH)
+            .with_sandbox_url("https://localhost")
+            .build()
+    )
+
+    token_request = (
+        YotiTokenRequest.builder().with_remember_me_id("remember_me_pls").build()
+    )
+
+    with pytest.raises(SandboxException) as ex:
+        client.setup_sharing_profile(token_request)
+        assert isinstance(ex.value, SandboxException)
+        assert ex.value.text == "Org not found"

yoti_python_sandbox/version.py

@@ -1 +1 @@
-__version__ = "1.0.0"
+__version__ = "1.0.1"