Skip to content

Commit 8ba7374

Browse files
bemyakKeats
authored andcommitted
fix: taxonomies missing lang in sitemap (#2373)
1 parent f560b48 commit 8ba7374

File tree

3 files changed

+14
-15
lines changed

3 files changed

+14
-15
lines changed

components/content/src/pagination.rs

+2-6
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,8 @@ impl<'a> Paginator<'a> {
107107
paginate_reversed: false,
108108
root: PaginationRoot::Taxonomy(taxonomy, item),
109109
permalink: item.permalink.clone(),
110-
path: format!("/{}/{}/", taxonomy.slug, item.slug),
111-
paginate_path: taxonomy
112-
.kind
113-
.paginate_path
114-
.clone()
115-
.unwrap_or_else(|| "page".to_string()),
110+
path: item.path.clone(),
111+
paginate_path: taxonomy.kind.paginate_path().to_owned(),
116112
is_index: false,
117113
template: template.to_string(),
118114
};

components/site/src/sitemap.rs

+4-9
Original file line numberDiff line numberDiff line change
@@ -92,24 +92,19 @@ pub fn find_entries<'a>(
9292
if !taxonomy.kind.render {
9393
continue;
9494
}
95-
let name = &taxonomy.kind.name;
96-
entries.insert(SitemapEntry::new(Cow::Owned(config.make_permalink(name)), &None));
95+
entries.insert(SitemapEntry::new(Cow::Borrowed(&taxonomy.permalink), &None));
9796

9897
for item in &taxonomy.items {
99-
entries.insert(SitemapEntry::new(
100-
Cow::Owned(config.make_permalink(&format!("{}/{}", name, item.slug))),
101-
&None,
102-
));
98+
entries.insert(SitemapEntry::new(Cow::Borrowed(&item.permalink), &None));
10399

104100
if taxonomy.kind.is_paginated() {
105101
let number_pagers = (item.pages.len() as f64
106102
/ taxonomy.kind.paginate_by.unwrap() as f64)
107103
.ceil() as isize;
108104
for i in 1..=number_pagers {
109105
let permalink = config.make_permalink(&format!(
110-
"{}/{}/{}/{}",
111-
name,
112-
item.slug,
106+
"{}{}/{}/",
107+
item.path,
113108
taxonomy.kind.paginate_path(),
114109
i
115110
));

components/site/tests/site_i18n.rs

+8
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,14 @@ fn can_build_multilingual_site() {
169169
assert!(file_contains!(public, "fr/tags/index.html", "bonjour"));
170170
assert!(!file_contains!(public, "fr/tags/index.html", "hello"));
171171

172+
// sitemap contains per-language taxonomies
173+
assert!(file_contains!(public, "sitemap.xml", "https://example.com/tags/"));
174+
assert!(file_contains!(public, "sitemap.xml", "https://example.com/tags/hello/"));
175+
assert!(file_contains!(public, "sitemap.xml", "https://example.com/fr/tags/"));
176+
assert!(file_contains!(public, "sitemap.xml", "https://example.com/fr/tags/bonjour/"));
177+
178+
assert!(!file_contains!(public, "sitemap.xml", "https://example.com/tags/bonjour"));
179+
172180
// one lang index per language
173181
assert!(file_exists!(public, "search_index.en.js"));
174182
assert!(file_exists!(public, "search_index.it.js"));

0 commit comments

Comments
 (0)