Skip to content

Commit 0c79d34

Browse files
committed
doc: pr template
1 parent 423a550 commit 0c79d34

1 file changed

Lines changed: 24 additions & 0 deletions

File tree

.github/pull_request_template.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# PR Title
2+
3+
Pull Request Description
4+
5+
## Related Issue
6+
7+
Resolves #ENTER_ISSUE_NUMBER
8+
9+
## Engineering Principles
10+
11+
- [ ] PR only contains changes strictly related to the requested feature or fix,
12+
scope is focused (no unrelated dependency updates or formatting)
13+
- [ ] This code totally respects [`README`](README.md)’s Engineering Principles
14+
15+
## CI/CD Readiness
16+
17+
- [ ] Branch follows Conventional Branch: `feat/…`, `fix/…`, `refactor/…`, …
18+
- [ ] Code is formatted with `dx fmt` AND `cargo fmt --all`
19+
- [ ] All checks pass, `nix flake checks` succeeds without warnings
20+
- [ ] Code compiles, `dx build` succeeds (with necessary platform flags)
21+
- [ ] NO `cargo clippy -- -D warnings -W clippy::all -W clippy::pedantic`
22+
warnings
23+
- [ ] All unit tests pass without warnings (`cargo test`)
24+
- [ ] End-to-end tests pass (`maestro test --headless maestro/{web,android}`)

0 commit comments

Comments
 (0)