Skip to content

Commit f3d2924

Browse files
committed
build: remove auto pagespeed insights, add psi and yellow labs links in readme
1 parent 8a3cbc6 commit f3d2924

3 files changed

Lines changed: 6 additions & 74 deletions

File tree

.github/workflows/cd.yml

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -86,39 +86,6 @@ jobs:
8686
- uses: actions/deploy-pages@v5
8787
id: deployment
8888

89-
pagespeed:
90-
if: github.ref == 'refs/heads/main' && needs.pwa-build-deploy.result == 'success'
91-
needs: pwa-build-deploy
92-
runs-on: ubuntu-latest
93-
timeout-minutes: 5
94-
steps:
95-
- uses: actions/checkout@v6
96-
- name: Run PageSpeed Insights on preview URL
97-
id: pagespeed
98-
run: |
99-
PREVIEW_URL="${{ needs.pwa-build-deploy.outputs.page_url }}preview/"
100-
echo "Running PageSpeed Insights on $PREVIEW_URL"
101-
RESULT=$(curl -sf \
102-
"https://www.googleapis.com/pagespeedonline/v5/runPagespeed?url=$(python3 -c "import urllib.parse,sys;print(urllib.parse.quote(sys.argv[1],safe=''))" "$PREVIEW_URL")&strategy=desktop${PAGESPEED_API_KEY:+&key=$PAGESPEED_API_KEY}" \
103-
|| echo '{}')
104-
PERF=$(echo "$RESULT" | jq -r '.lighthouseResult.categories.performance.score // "N/A"')
105-
A11Y=$(echo "$RESULT" | jq -r '.lighthouseResult.categories.accessibility.score // "N/A"')
106-
BP=$(echo "$RESULT" | jq -r '.lighthouseResult.categories["best-practices"].score // "N/A"')
107-
SEO=$(echo "$RESULT" | jq -r '.lighthouseResult.categories.seo.score // "N/A"')
108-
PWA=$(echo "$RESULT" | jq -r '.lighthouseResult.categories.pwa.score // "N/A"')
109-
echo "performance=$PERF" >> "$GITHUB_OUTPUT"
110-
echo "accessibility=$A11Y" >> "$GITHUB_OUTPUT"
111-
echo "best_practices=$BP" >> "$GITHUB_OUTPUT"
112-
echo "seo=$SEO" >> "$GITHUB_OUTPUT"
113-
echo "pwa=$PWA" >> "$GITHUB_OUTPUT"
114-
echo "preview_url=$PREVIEW_URL" >> "$GITHUB_OUTPUT"
115-
echo "### 🚀 PageSpeed Insights (preview)" >> "$GITHUB_STEP_SUMMARY"
116-
echo "| URL | Perf | A11y | Best Practices | SEO | PWA |" >> "$GITHUB_STEP_SUMMARY"
117-
echo "| --- | ---- | ---- | -------------- | --- | --- |" >> "$GITHUB_STEP_SUMMARY"
118-
echo "| $PREVIEW_URL | $PERF | $A11Y | $BP | $SEO | $PWA |" >> "$GITHUB_STEP_SUMMARY"
119-
env:
120-
PAGESPEED_API_KEY: ${{ secrets.PAGESPEED_API_KEY }}
121-
12289
e2e-web-preview:
12390
if: github.ref == 'refs/heads/main' && needs.pwa-build-deploy.result == 'success'
12491
needs: pwa-build-deploy

.github/workflows/ci.yml

Lines changed: 1 addition & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -116,46 +116,7 @@ jobs:
116116
- uses: actions/upload-artifact@v4
117117
with: { name: android, path: '*.apk' }
118118

119-
# lighthouse: FIXME
120-
# if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
121-
# needs: coverage
122-
# runs-on: ubuntu-latest
123-
# timeout-minutes: 20
124-
# steps:
125-
# - uses: actions/checkout@v6
126-
# - uses: cachix/install-nix-action@v31
127-
# with:
128-
# github_access_token: ${{ secrets.GITHUB_TOKEN }}
129-
# extra_nix_config: | # TODO Ensure nix uses the most performant cache between Garnix and Cachix every time
130-
# extra-substituters = https://cache.garnix.io
131-
# extra-trusted-public-keys = cache.garnix.io:CTFPyKSLcx5RMJKfLo5EEPUObbA78b0YQ2DTCJXqr9g=
132-
# - uses: cachix/cachix-action@v17
133-
# with:
134-
# name: gfauredev
135-
# authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}'
136-
# - name: Start web app server
137-
# run: |
138-
# nix run &
139-
# timeout 60 bash -c 'until curl -sf http://localhost:8080/LogOut/ > /dev/null 2>&1; do sleep 1; done'
140-
# - uses: treosh/lighthouse-ci-action@v12
141-
# with:
142-
# urls: http://localhost:8080/LogOut/
143-
# uploadArtifacts: true
144-
# temporaryPublicStorage: true
145-
# configPath: .lighthouserc.json
146-
# id: lighthouse_audit
147-
# - if: always() && github.event_name == 'pull_request'
148-
# run: .script/lighthouse-report.sh '${{ steps.lighthouse_audit.outputs.links }}'
149-
# id: lighthouse_results
150-
# - if: always() && github.event_name == 'pull_request'
151-
# uses: peter-evans/create-or-update-comment@v5
152-
# with:
153-
# issue-number: ${{ github.event.pull_request.number }}
154-
# body: ${{ steps.lighthouse_results.outputs.BODY }}
155-
156-
# e2e-web: Moved to CD pipeline — runs against the public preview URL
157-
# after every successful Pages deployment (see cd.yml e2e-web-preview job).
158-
# e2e-web:
119+
# e2e-web: # Moved to CD to run against the public preview URL on Pages deploy
159120
# if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
160121
# needs: coverage
161122
# runs-on: ubuntu-latest

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,6 @@ PRs) must pass (for some, at a certain level) for it to be merged into `main`.
233233
- Check that more than `80%` of code (excluding `components`) is covered,
234234
publish the full coverage summary table as a PR comment
235235
- Slower checks, only if above pass _and_ branch is up-to-date with `main`
236-
- **PageSpeed** Lighthouse audit on PWA, publish report as a PR comment
237236
- Web Maestro **end-to-end tests** with `maestro test maestro/web`
238237
- Publish a report with screenshots of failed E2E tests as a PR comment
239238

@@ -254,6 +253,9 @@ a “Stable” GitHub Release with a production Android APK built on this `tag`.
254253
Additionally, [renovate] GitHub app is used to monitor the freshness of
255254
project’s dependencies.
256255

256+
The site can also be analysed with [PageSpeed Insights] and [Yellow Labs] to
257+
further improve its quality.
258+
257259
### Heavier Checks
258260

259261
[LogOut] ensures high quality code with additional resource intensive checks
@@ -303,6 +305,7 @@ The [exercise database] is under the Unlicense (public domain).
303305
[nextest]: https://nexte.st
304306
[Nix]: https://nixos.org
305307
[pwa]: https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps
308+
[pagespeed insights]: https://pagespeed.web.dev/analysis/https-gfauredev-github-io-LogOut-preview/0wfwmlcief
306309
[renovate]: https://www.mend.io/renovate
307310
[rust-analyzer]: https://rust-analyzer.github.io
308311
[rust]: https://www.rust-lang.org
@@ -319,4 +322,5 @@ The [exercise database] is under the Unlicense (public domain).
319322
[Reqwest]: https://github.com/seanmonstar/reqwest
320323
[Time]: https://github.com/time-rs/time
321324
[Tokio]: https://tokio.rs
325+
[yellow labs]: https://yellowlab.tools/result/hhereygo8j
322326
[Web-sys]: https://rustwasm.github.io/wasm-bindgen/web-sys/index.html

0 commit comments

Comments
 (0)