-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Labels
area: denoDeno bindings to wgpuDeno bindings to wgpuarea: infrastructureTesting, building, coordinating issuesTesting, building, coordinating issuesdependenciesPull requests that update a dependency filePull requests that update a dependency filetype: trackingNot a bug or an enhancementNot a bug or an enhancement
Description
Description
Trying to upgrade wgpu in the current deno with the current wgpu version fails due to changes in interfaces (in particular GarbageCollected needs a get_name.
Repro steps
After following the instructions for Deno here, deno does not compile anymore.
Expected vs observed behavior
I get several compiler errors, most relating to the get_name method not defined for different types implementing the GarbageCollected trait. Example:
error[E0046]: not all trait items implemented, missing: `get_name`
--> ext/webgpu/lib.rs:129:1
|
129 | impl GarbageCollected for GPU {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `get_name` in implementation
|
= help: implement the missing item: `fn get_name(&self) -> &'static CStr { todo!() }
After adding dummy implementations for this method, there are errors from the deno jupyter.rs module requiring the device and queue context from texture which does not seem to be there anymore.
Platform
Compiling on Ubuntu Linux 24.04 with rust 1.86.0
Metadata
Metadata
Assignees
Labels
area: denoDeno bindings to wgpuDeno bindings to wgpuarea: infrastructureTesting, building, coordinating issuesTesting, building, coordinating issuesdependenciesPull requests that update a dependency filePull requests that update a dependency filetype: trackingNot a bug or an enhancementNot a bug or an enhancement