Some rephrasing

Author: mephenor

tests/fixtures/aem_pack.py

@@ -149,9 +149,9 @@ async def process_pack(
 def mock_registry() -> AEMPackRegistry:
     """An AEMPackRegistry wired with mocked collaborators.
 
-    Suitable for tests that exercise only the pure in-memory methods
-    (``_traverse_graph``, ``_create_aem_pack``, ``_apply_workflow_to_data``) and
-    therefore do not need Mongo/Kafka containers.
+    Suitable for tests that exercise only the in-memory methods `_traverse_graph`,
+    `_create_aem_pack` and ``_apply_workflow_to_data`, which do not need Mongo/Kafka
+    containers.
     """
     return AEMPackRegistry(
         config=MagicMock(spec=Config),

tests/fixtures/examples.py

@@ -13,9 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-"""Example configs: paths, loaders, schemas, and the parametrize fixtures that
-consume them. One module for everything driven by YAML/JSON fixture files.
-"""
+"""Fixtures for example transformation configs and mock schema."""
 
 import contextlib
 import json
@@ -42,10 +40,10 @@
 
 @cache
 def _examples_in(subpath: str) -> Mapping[str, Path]:
-    """Return ``{stem: path}`` for files under ``CONFIG_DIR / subpath``, sorted by stem.
+    """Return `{stem: path}` for files under `CONFIG_DIR / subpath`, sorted by stem.
 
-    The result is a read-only ``MappingProxyType`` because ``@cache`` shares one
-    instance across callers — mutation would silently corrupt the cache.
+    The result is a read-only `MappingProxyType` because `@cache` shares one instance
+    across callers and mutation would silently corrupt the cache.
     """
     return MappingProxyType(
         dict(
@@ -55,7 +53,7 @@ def _examples_in(subpath: str) -> Mapping[str, Path]:
 
 
 def _examples_by_prefix(subpath: str, prefix: str) -> Mapping[str, Path]:
-    """Return ``{stem-without-prefix: path}`` for prefixed files under ``subpath``."""
+    """Return `{stem-without-prefix: path}` for prefixed files under `subpath`."""
     return {
         stem.removeprefix(prefix): path
         for stem, path in _examples_in(subpath).items()
@@ -65,9 +63,9 @@ def _examples_by_prefix(subpath: str, prefix: str) -> Mapping[str, Path]:
 
 @contextlib.contextmanager
 def _cwd(path: Path) -> Iterator[None]:
-    """Chdir to ``path`` for the block; restore on exit.
+    """Chdir to `path` for the block; restore on exit.
 
-    Required so schemapack's content-schema validator resolves ``content: ../foo.json``
+    Required so schemapack's content-schema validator resolves `content: ../foo.json`
     references relative to the YAML fixture's own directory, not the test runner's cwd.
     """
     original = os.getcwd()
@@ -81,7 +79,7 @@ def _cwd(path: Path) -> Iterator[None]:
 def _load[ModelT: BaseModel](
     path: Path, model: type[ModelT], *, section: str | None = None
 ) -> ModelT:
-    """Load and validate ``model`` from a YAML fixture (optionally a sub-section)."""
+    """Load and validate `model` from a YAML fixture."""
     with path.open("r") as fh:
         data = safe_load(fh)
     if section is not None:
@@ -91,17 +89,17 @@ def _load[ModelT: BaseModel](
 
 
 def load_validated_config(path: Path) -> ValidatedConfig:
-    """Load a ``ValidatedConfig`` from a YAML fixture file."""
+    """Load a `ValidatedConfig` from a YAML fixture file."""
     return _load(path, ValidatedConfig)
 
 
 def load_raw_config(path: Path) -> RawConfig:
-    """Load a ``RawConfig`` from a YAML fixture file."""
+    """Load a `RawConfig` from a YAML fixture file."""
     return _load(path, RawConfig)
 
 
 def load_pruning_config(path: Path) -> ValidatedConfig:
-    """Load a ``ValidatedConfig`` from a pruning-case YAML's ``config:`` section."""
+    """Load a `ValidatedConfig` from a pruning-case YAML's `config` section."""
     return _load(path, ValidatedConfig, section="config")
 
 
@@ -111,7 +109,7 @@ def load_aem_pack_config(
 ) -> PersistedConfig:
     """Load a YAML config, derive schemas, and return a PersistedConfig.
 
-    ``publish_models`` flips ``publish=True`` on the named models.
+    `publish_models` sets `publish=True` on all models named in the collection.
     """
     validated = load_validated_config(path)
     deriver = ModelDeriver()
@@ -196,12 +194,12 @@ def model_derivation_fixture(
 def mock_apply_workflow(
     model_derivation_fixture: ModelDerivationFixture,
 ) -> Generator[MagicMock]:
-    """Patch ``_apply_workflow`` on the deriver and yield the mock."""
+    """Patch `_apply_workflow` on the deriver and yield the mock."""
     with patch.object(model_derivation_fixture.deriver, "_apply_workflow") as mock:
         yield mock
 
 
 @pytest.fixture
 def pruning_fixture(request: pytest.FixtureRequest) -> Generator[ValidatedConfig]:
-    """Load a ``ValidatedConfig`` from the YAML's ``config:`` section, via ``indirect``."""
+    """Load a `ValidatedConfig` from the YAML's `config:` section, via `indirect`."""
     yield load_pruning_config(request.param)

tests/fixtures/joint.py

@@ -90,7 +90,7 @@ async def seed_config(
     ) -> PersistedConfig:
         """Derive a config from a YAML fixture and write it to the DB.
 
-        Returns the PersistedConfig matching what ``load_config_from_db`` returns.
+        Returns the PersistedConfig matching `load_config_from_db`.
         """
         config = load_aem_pack_config(config_yaml_path, publish_models=publish_models)
         await self.insert_config(config)

tests/fixtures/mongo.py

@@ -28,6 +28,9 @@
 async def mongo_collection(
     request: pytest.FixtureRequest, mongodb: MongoDbFixture
 ) -> AsyncGenerator[AsyncCollection]:
-    """Yield a single MongoDB collection by name (passed via ``indirect``)."""
+    """Yield a single MongoDB collection by name, passed via `indirect`.
+
+    `request.param` holds the collection name.
+    """
     async with ConfiguredMongoClient(config=mongodb.config) as client:
         yield client[mongodb.config.db_name][request.param]

tests/test_aem_pack_registry/test_config_changes.py

@@ -13,13 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-"""Tests for processing under config inconsistencies and mid-flight changes.
-
-Covers behavior when the persisted config differs from what was current at the
-time a pack was queued: routes/models removed (cleanup of stale derived packs),
-the graph config version bumping mid-process (pack freed for reprocessing), and
-a pack referencing a model that no longer exists (error propagation).
-"""
+"""Tests for processing under config inconsistencies and mid-flight changes."""
 
 import logging
 from unittest.mock import AsyncMock, patch

…t_aem_pack_registry/test_pure_helpers.py …_pack_registry/test_in_memory_methods.pytests/test_aem_pack_registry/test_pure_helpers.py renamed to tests/test_aem_pack_registry/test_in_memory_methods.py tests/test_aem_pack_registry/test_pure_helpers.py renamed to tests/test_aem_pack_registry/test_in_memory_methods.py

@@ -13,21 +13,12 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-"""Tests for the pure in-memory methods of AEMPackRegistry.
-
-These tests run against a ``mock_registry`` (collaborators are mocks) and do
-not need MongoDB or Kafka. Covered methods:
-
-* ``_create_aem_pack`` and ``_apply_workflow_to_data`` — wrapper helpers
-* ``_traverse_graph`` — the routing/publishing core, exercised with a range of
-  graph topologies
-"""
+"""Tests for the in-memory methods of AEMPackRegistry."""
 
 from uuid import uuid4
 
 import pytest
 from pydantic import UUID4
-from schemapack.spec.datapack import DataPack
 
 from ets.core.aem_pack_registry import AEMPackRegistry
 from ets.core.models import AEMPack, Model, PersistedConfig
@@ -44,7 +35,7 @@ def _ingress_model(config: PersistedConfig) -> Model:
 
 
 def _ingress_for(config: PersistedConfig, name: str | None = None) -> AEMPack:
-    """Build an ingress AEMPack (defaults to the configured ingress model)."""
+    """Build an ingress AEMPack. Defaults to the configured ingress model."""
     return AEMPack(
         id=uuid4(),
         model_name=name or _ingress_model(config).name,
@@ -60,7 +51,7 @@ def _traverse(
     dirty_map: dict[str, UUID4],
     config: PersistedConfig,
 ) -> tuple[list[AEMPack], dict[str, UUID4]]:
-    """Run ``_traverse_graph`` seeding ``transformed_map`` with the incoming pack."""
+    """Run `_traverse_graph` seeding `transformed_map` with the incoming pack."""
     return mock_registry._traverse_graph(
         incoming=incoming,
         dirty_map=dirty_map,
@@ -69,9 +60,6 @@ def _traverse(
     )
 
 
-# --- _create_aem_pack / _apply_workflow_to_data ------------------------------
-
-
 @pytest.mark.parametrize(
     "aem_id,expected_aem_id",
     [(None, False), (EXPECTED_AEM_ID, True)],
@@ -80,7 +68,7 @@ def _traverse(
 def test_create_aem_pack(
     mock_registry: AEMPackRegistry, aem_id: UUID4 | None, expected_aem_id: bool
 ):
-    """Creating an AEMPack wrapper, with and without a pre-specified ID."""
+    """Ensure creating an AEMPack wrapper works, with and without a pre-specified ID."""
     aem_pack = mock_registry._create_aem_pack(
         aem_id=aem_id,
         model_name="TestModel",
@@ -98,26 +86,6 @@ def test_create_aem_pack(
         assert aem_pack.id == EXPECTED_AEM_ID
 
 
-def test_apply_workflow_to_data(mock_registry: AEMPackRegistry):
-    """Applying a workflow transforms only the schema, not the resource data."""
-    config = load_aem_pack_config(AEM_PACK_REGISTRY_CONFIGS["single_route"])
-    ingress = _ingress_model(config)
-
-    result = mock_registry._apply_workflow_to_data(
-        data=TEST_DATAPACK,
-        annotation={},
-        input_schema=ingress.schema_,
-        workflow=config.workflows[0],
-    )
-
-    assert isinstance(result, DataPack)
-    # rename_id_property only modifies the schema, not the resource data.
-    assert result.resources == TEST_DATAPACK.resources
-
-
-# --- _traverse_graph ---------------------------------------------------------
-
-
 @pytest.mark.parametrize(
     "aem_pack_config, dirty_names",
     [
@@ -148,8 +116,8 @@ def test_clears_dirty_map(
     aem_pack_config: PersistedConfig,
     dirty_names: set[str],
 ):
-    """Traversal clears all non-dangling dirty map entries and only publishes
-    derived packs whose model has ``publish=True``.
+    """Ensure traversal clears all non-dangling dirty map entries and only publishes
+    derived packs whose model has `publish=True`.
     """
     incoming = _ingress_for(aem_pack_config)
     dirty_map: dict[str, UUID4] = {name: uuid4() for name in dirty_names}
@@ -165,7 +133,7 @@ def test_clears_dirty_map(
 
 
 def test_respects_topological_order(mock_registry: AEMPackRegistry):
-    """Routes are processed in topological order regardless of fixture listing order."""
+    """Ensure routes are processed in topological order regardless of fixture listing order."""
     config = load_aem_pack_config(AEM_PACK_REGISTRY_CONFIGS["forking_routes"])
     # Swap orders so DerivedModel2 (order=1) is processed before DerivedModel1 (order=2)
     by_name = {model.name: model for model in config.models}
@@ -203,9 +171,7 @@ def test_dirty_map_id_handling(
     have_dirty_map: bool,
     expected_published: int,
 ):
-    """With a dirty map, derived packs reuse the supplied UUIDs; without one,
-    fresh UUIDs are generated for each derived pack.
-    """
+    """Ensure derived packs reuse the supplied UUIDs from the dirty map."""
     config = load_aem_pack_config(
         AEM_PACK_REGISTRY_CONFIGS[config_name], publish_models=publish
     )
@@ -246,7 +212,7 @@ def test_bottleneck_topology(
     aem_pack_config: PersistedConfig,
     ingress_name: str,
 ):
-    """Traversal from each ingress through a bottleneck publishes downstream
+    """Ensure traversal from each ingress through a bottleneck publishes downstream
     and reuses existing dirty-map IDs for the derived packs.
     """
     incoming = _ingress_for(aem_pack_config, name=ingress_name)

tests/test_aem_pack_registry/test_pipeline.py

@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-"""Test different configurations with end-to-end tests: queue → claim → process → verify derived packs."""
+"""Test different configurations with end-to-end tests: queue - claim - process - verify derived packs."""
 
 from uuid import uuid4