Merge pull request #27 from ghost-wallet/js-number-fixes

Fix various numeric precision issues

Author: cg-ghost

src/hooks/chainge/fetchAggregateQuote.ts

@@ -22,7 +22,7 @@ const API_URL = 'https://api2.chainge.finance/v1/getAggregateQuote'
 export const fetchAggregateQuote = async (
   fromToken: ChaingeToken,
   toToken: ChaingeToken,
-  fromAmount: bigint,
+  fromAmount: string,
   options: { signal?: AbortSignal } = {},
 ): Promise<ChaingeAggregateQuote | undefined> => {
   try {

src/hooks/chainge/useAggregateQuote.ts

@@ -2,6 +2,7 @@ import { useEffect, useState } from 'react'
 import { ChaingeAggregateQuote, fetchAggregateQuote } from '@/hooks/chainge/fetchAggregateQuote'
 import { formatNumberWithDecimal } from '@/utils/formatting'
 import { ChaingeToken } from '@/hooks/chainge/useChaingeTokens'
+import { parseUnits } from 'ethers'
 
 // TODO refetch every 15 seconds
 const useAggregateQuote = (
@@ -18,11 +19,6 @@ const useAggregateQuote = (
     const controller = new AbortController()
     const { signal } = controller
 
-    const formatPayAmountToBigInt = (amount: number, decimals: number): bigint => {
-      const scaledAmount = Math.round(amount * Math.pow(10, decimals))
-      return BigInt(scaledAmount)
-    }
-
     const fetchQuote = async () => {
       if (!payAmount || !(Number(payAmount) > 0)) {
         setReceiveAmount('')
@@ -34,7 +30,7 @@ const useAggregateQuote = (
         await new Promise((resolve) => setTimeout(resolve, 200))
         setError(null)
         try {
-          const adjustedPayAmount = formatPayAmountToBigInt(parseFloat(payAmount), payToken.decimals)
+          const adjustedPayAmount = parseUnits(payAmount, payToken.decimals).toString()
           const quote = await fetchAggregateQuote(payToken, receiveToken, adjustedPayAmount, { signal })
           setAggregateQuote(quote)
           if (quote) {

src/hooks/ghost/fetchPriceV2.ts

@@ -24,7 +24,7 @@ export const fetchPriceV2 = async (currency: string, names: string): Promise<Pri
 
     const data = await response.json()
 
-    console.log('Cloudflare json response:', JSON.stringify(data, null, 2))
+    //console.log('Cloudflare json response:', JSON.stringify(data, null, 2))
 
     if (!data || typeof data.source !== 'string' || typeof data.currency !== 'string' || !data.prices) {
       console.error('Cloudflare response data structure wrong')

src/pages/Wallet/Swap.tsx

@@ -54,10 +54,7 @@ export default function Swap() {
     try {
       request('account:estimateChaingeTransactionFee', [
         {
-          fromAmount:
-            payToken.symbol !== KAS_TICKER
-              ? Math.round(Number(payAmount) * Math.pow(10, payToken.decimals)).toString()
-              : payAmount,
+          fromAmount: payAmount,
           fromToken: payToken,
           feeRate,
         },

src/wallet/krc20/KRC20Transactions.ts

@@ -22,6 +22,7 @@ import AccountTransactions from '../account/AccountTransactions'
 import { KRC20TokenRequest, TokenFromApi } from '@/utils/interfaces'
 import { KRC20Inscription } from './KRC20Inscription'
 import { KRC20_COMMIT_AMOUNT } from '@/utils/constants/constants'
+import { parseUnits } from 'ethers'
 
 export type Token = TokenFromApi
 
@@ -36,7 +37,7 @@ function setupKrc20Transaction(
   const script = new ScriptBuilder()
   const inscription = new KRC20Inscription('transfer', {
     tick,
-    amt: BigInt(+amount * 10 ** +dec).toString(),
+    amt: parseUnits(amount, dec).toString(),
     to: recipient,
   })