Skip to content

Commit f8d2c9d

Browse files
committed
Add KeysMargin Property for Shortcut #103
1 parent b2a0a4f commit f8d2c9d

File tree

4 files changed

+16
-5
lines changed

4 files changed

+16
-5
lines changed

dev/DevWinUI.Controls/Controls/Shortcut/BaseShortcut.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
namespace DevWinUI;
22
public partial class BaseShortcut : Control
33
{
4+
public Thickness KeysMargin
5+
{
6+
get { return (Thickness)GetValue(KeysMarginProperty); }
7+
set { SetValue(KeysMarginProperty, value); }
8+
}
9+
10+
public static readonly DependencyProperty KeysMarginProperty =
11+
DependencyProperty.Register(nameof(KeysMargin), typeof(Thickness), typeof(BaseShortcut), new PropertyMetadata(new Thickness(0, 64, 0, 0), OnPropertyChanged));
12+
413
public string Title
514
{
615
get { return (string)GetValue(TitleProperty); }

dev/DevWinUI.Controls/Controls/Shortcut/Shortcut.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,7 @@ private void UpdateProperties()
156156
shortcut.IsError = IsError;
157157
shortcut.ErrorTitle = ErrorTitle;
158158
shortcut.ErrorToolTip = ErrorToolTip;
159+
shortcut.KeysMargin = KeysMargin;
159160
}
160161
}
161162

@@ -195,6 +196,7 @@ private async void OpenDialog_Click(object sender, RoutedEventArgs e)
195196

196197
shortcut.Keys = null;
197198
shortcut.Keys = Keys;
199+
shortcut.KeysMargin = KeysMargin;
198200

199201
shortcut.InfoTitle = InfoTitle;
200202
shortcut.InfoToolTip = InfoToolTip;

dev/DevWinUI.Controls/Themes/Generic.xaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2640,13 +2640,13 @@ Themes\Styles\Win2D\Watermark.xaml
26402640
<Grid MinHeight="{TemplateBinding MinHeight}">
26412641
<Grid.RowDefinitions>
26422642
<RowDefinition Height="Auto" />
2643-
<RowDefinition MinHeight="110" />
2643+
<RowDefinition />
26442644
<RowDefinition Height="Auto" />
26452645
</Grid.RowDefinitions>
26462646
<!-- Fix InfoBar Cut off Right Edges -->
26472647
<Border x:Name="PART_Border" />
26482648
<TextBlock Grid.Row="0" Text="{TemplateBinding Title}" TextWrapping="Wrap" />
2649-
<ItemsControl x:Name="KeysItemsControl" Grid.Row="1" Margin="0,64,0,0" HorizontalAlignment="Center" VerticalAlignment="Top" HorizontalContentAlignment="Center" ItemsSource="{TemplateBinding Keys}" Tag="{TemplateBinding IsError}">
2649+
<ItemsControl x:Name="KeysItemsControl" Grid.Row="1" Margin="{TemplateBinding KeysMargin}" HorizontalAlignment="Center" VerticalAlignment="Top" HorizontalContentAlignment="Center" ItemsSource="{TemplateBinding Keys}" Tag="{TemplateBinding IsError}">
26502650
<ItemsControl.ItemsPanel>
26512651
<ItemsPanelTemplate>
26522652
<StackPanel Orientation="Horizontal" Spacing="8" />
@@ -8350,10 +8350,10 @@ Themes\Styles\Win2D\Watermark.xaml
83508350
<ContentPresenter Content="{TemplateBinding Source}" />
83518351
</Grid>
83528352
</ScrollViewer>
8353-
<Button x:Name="PART_ScrollBackBtn" Width="16" Height="38" Margin="8,-16,0,0" AutomationProperties.Name="{TemplateBinding ScrollBackButtonToolTipText}" BorderThickness="0" Style="{StaticResource ScrollButtonStyle}" ToolTipService.ToolTip="{TemplateBinding ScrollBackButtonToolTipText}" Visibility="Collapsed">
8353+
<Button x:Name="PART_ScrollBackBtn" Width="16" Height="38" Margin="8,-16,0,0" AutomationProperties.Name="{TemplateBinding ScrollBackButtonToolTipText}" Style="{StaticResource ScrollButtonStyle}" ToolTipService.ToolTip="{TemplateBinding ScrollBackButtonToolTipText}" Visibility="Collapsed">
83548354
<FontIcon FontSize="{ThemeResource FlipViewButtonFontSize}" Glyph="" />
83558355
</Button>
8356-
<Button x:Name="PART_ScrollForwardBtn" Width="16" Height="38" Margin="0,-16,8,0" HorizontalAlignment="Right" AutomationProperties.Name="{TemplateBinding ScrollForwardButtonToolTipText}" BorderThickness="0" Style="{StaticResource ScrollButtonStyle}" ToolTipService.ToolTip="{TemplateBinding ScrollForwardButtonToolTipText}">
8356+
<Button x:Name="PART_ScrollForwardBtn" Width="16" Height="38" Margin="0,-16,8,0" HorizontalAlignment="Right" AutomationProperties.Name="{TemplateBinding ScrollForwardButtonToolTipText}" Style="{StaticResource ScrollButtonStyle}" ToolTipService.ToolTip="{TemplateBinding ScrollForwardButtonToolTipText}">
83578357
<FontIcon FontSize="{ThemeResource FlipViewButtonFontSize}" Glyph="" />
83588358
</Button>
83598359
</Grid>

dev/DevWinUI.Controls/Themes/Styles/Controls/Shortcut.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171

7272
<ItemsControl x:Name="KeysItemsControl"
7373
Grid.Row="1"
74-
Margin="0,64,0,0"
74+
Margin="{TemplateBinding KeysMargin}"
7575
HorizontalAlignment="Center"
7676
VerticalAlignment="Top"
7777
HorizontalContentAlignment="Center"

0 commit comments

Comments
 (0)