The char "8️⃣" should take up two columns bc it has the FE0F codepoint

[erf]

I noticed that "8️⃣" (U+20E3 , U+FE0F) has the emoji presentation variation selector, but is rendered as a char of column width 1 - that is it looks like it should take up two chars but it just overlaps with the next char.

Try to cat this or open this in an editor that can handle Unicode characters and notice how the "8️⃣" is overlapped.

Screenshot:

Test text:

abcd
☺️abcd
8️⃣abcd

Test file:
eight.txt

[00-kat]

P.S.: eight.txt is empty.

Reupload: eight.txt. Huh my eight.txt is also empty...

[mitchellh]

It is not empty for me.

[gigamonster256]

Removing these lines resolves the issue

ghostty/src/terminal/Terminal.zig

Lines 343 to 346 in 0306c59

	// This only applies to emoji
	const prev_props = unicode.getProperties(prev.cell.content.codepoint);
	const emoji = prev_props.grapheme_boundary_class.isExtendedPictographic();
	if (!emoji) return;

Although perhaps there could be a cleaner solution for these special "emojified keycap characters"

see the different behavior on the 3 following files
just_eight.txt (0x38)
keycap_eight.txt (0x38, U+20E3)
emoji_eight.txt (0x38, U+FE0F, U+20E3)

[gigamonster256]

Note: this does not fix the issue that "keycap eight" (0x38, U+20E3) is reported as cell width narrow instead of wide

[erf]

Yes i don't think isExtendedPictographic should override the variation selector.

[mitchellh]

Yes i don't think isExtendedPictographic should override the variation selector.

I think we have a data table issue because the variation selectors are specified to only affect emoji class code points. They’re supposed to be ignored for the rest. I need to look at our tables to see what’s going on

[gigamonster256]

Side note, the emoji character you chose to demostrate the behavior "☺️" is rendering fine with cat but behaving strangely in neovim (a blank cell is rendered unless the emoji is part of the most recent visual selection)

[erf]

Neovim does not correctly render grapheme clusters. I think nano does though.