apprt/gtk: Even if surface looks like it has focus, it doesn't

[tristan957]

I haven't been able to reproduce reliably, but here is a video which should describe the issue. If I push the up arrow key, my focus moves into the headerbar, which is not what I want. I want to go through my shell history.

Screencast.From.2025-03-19.10-06-41.mp4

[mitchellh]

This was an issue very very long ago, like when I first did GTK ever. There is a function call I called early on (with a comment) that disables this behavior. Perhaps:

1. That got removed with the gobject PRs
2. That isn't working anymore (for whatever reason)
3. That needs to happen elsewhere

For what its worth, this isn't happening for me, so it may be a recent Adw/Gtk bug/feature (who ever knows, they seem to flip flop behavior every patch release):

Version
  - version: 1.1.3-HEAD+907e62aa
  - channel: tip
Build Config
  - Zig version: 0.14.0
  - build mode : builtin.OptimizeMode.Debug
  - app runtime: apprt.Runtime.gtk
  - font engine: font.main.Backend.fontconfig_freetype
  - renderer   : renderer.OpenGL
  - libxev     : io_uring
  - desktop env: gnome
  - GTK version:
    build      : 4.16.12
    runtime    : 4.16.12
  - libadwaita : enabled
    build      : 1.6.2
    runtime    : 1.6.2
  - libX11     : enabled
  - libwayland : enabled

[tristan957]

@pluiedev and @jcollie maybe y'all have some inkling of this as y'all have moved to zig-gobject? This is definitely a recent regression. Like I think yesterday was the first day I ran into this issue and I pull regularly.

[pluiedev]

Can't repro on my end... dunno what's going on here either. IIRC we do set the headerbar buttons to be unfocusable but perhaps we missed one?

[tristan957]

I need to try to reproduce while the GTK inspector is running. Then I can do a little bit more investigating.

[tristan957]

If I start to type letters, then I can workaround the issue.

[tristan957]

Not having a repro is really freaking annoying for purposes of trying to bisect.

[jcollie]

Just a shot in the dark, but does this patch fix it?

diff --git a/src/apprt/gtk/Window.zig b/src/apprt/gtk/Window.zig
index 2866c5ede..94250e78e 100644
--- a/src/apprt/gtk/Window.zig
+++ b/src/apprt/gtk/Window.zig
@@ -237,6 +237,7 @@ pub fn init(self: *Window, app: *App) !void {
             },
         };

+        btn.setCanFocus(0);
         btn.setFocusOnClick(0);
         self.headerbar.packEnd(btn);
     }