Default binding for ctrl-shift-plus #7243
Replies: 5 comments 14 replies
-
|
Interesting. Just as a note: we can add multiple bindings to a single action, and the last binding usually wins for showing up in menu accelerators (since those usually only one). |
Beta Was this translation helpful? Give feedback.
-
Firefox also allows ctrl+shift+-, but I'm not sure how common that is among other applications. |
Beta Was this translation helpful? Give feedback.
-
|
I think the confusion here comes from how https://github.com/ghostty-org/ghostty/blob/main/src/config/Config.zig#L4394-L4407 On US style layouts and (GB in this case) it is impossible to generate the plus is the only key that I found on a us layout which does not match this behavior where you would expect that on your note about firefox
Here is another discussion about this "odd" behavior of the plus keycode I've tried to find a answer to why this happens online but I can't find any information on this topic some reason, I do know that this is how ghostty receives the keycode from GTK though and there is not anything ghostty can do to change that |
Beta Was this translation helpful? Give feedback.
-
|
Can I just go ahead for a PR? |
Beta Was this translation helpful? Give feedback.
-
|
I created a PR to add default keybinding: #9688 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
On some keyboard layouts plus is produced by holding shift. On both en_US, and en_GB keyboard my computer will cause the inspector to output "Shift+Ctrl+plus" for this combination.
Surprisignly this does not increase the font size.
Other applications like firefox does accept this keybinding to enlarge font size.
For a more expected default behavior, I propose to add
keybind = ctrl+shift+plus=increase_font_size:1to the default config.(experienced on ghostty version:
1.1.4-main+2b4f1f8b)Previous discussion held on discord: https://discord.com/channels/1005603569187160125/1367430523361824779
Beta Was this translation helpful? Give feedback.
All reactions