Expand arbitrary string patterns into URLs #9545
Replies: 2 comments 2 replies
-
This doesn't exist. We only have to run the regex scanner on a line where the mouse is. We can ignore the rest. So it's still very efficient. This is already how all URLs (even OSC8!) work today. |
Beta Was this translation helpful? Give feedback.
-
|
Of the three successor to #4379, would this issue here be the one that covers clicking local file paths (relative to Or are these three issues strictly referring to URLs, and if so would another successor/issue be welcome? |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Successor to #4379 (and also #2394).
The basic idea is that terminal should be able to expand any string within an arbitrary user-provided pattern like
GH-114514into a URL likehttps://github.com/someuser/somerepo/issues/114514, which can then be Ctrl/Cmd-clicked and run.From a maintainer's perspective I worry about the complexity of this feature and how it could potentially greatly increase the I/O overhead of scanning each line for valid pattern matches, similar to what we already do for non-OSC 8 URLs. If someone were able to implement this without massively sacrificing performance, though, then I could potentially change my mind.
Beta Was this translation helpful? Give feedback.
All reactions