macOS: Cmd + Shift + Plus should increase font size too

[mitchellh]

Discussed in #3888

^{Originally posted by thiagowfx December 29, 2024}
Out-of-the-box, the shortcut to increase/decrease font sizes in Ghostty on macOS is Cmd + + and Cmd + -, respectively (no Shift).

With Shift:

Observed: Cmd + Shift + + inserts a literal '+', and Cmd + Shift + - decreases the font size.

Expected: Cmd + Shift + + should increase the font size as well, consistently.

Why is the behavior for Cmd + Shift + + different? This seems unintentional.

Note that this is the out-of-the-box behavior in both Terminal.app and iTerm2.

[mitchellh]

Note: the solution here doesn't appear on the surface to be a missing binding (but may be). Some research is required why cmd+shift+- works but not plus on macOS currently.

[alexhollinghead]

I'm not able to reproduce this on 15.1 Sequoia; both CMD + Shift + + and CMD + Shift + - adjust the font size for me. I do already have font size manually configured in my config file. Could this account for your issue?

[curtbushko]

I can reproduce this on Sequoia 15.2.

Cmd + Shift + + gives me = in my shell.
Cmd + Shift + - reduces the font size.

From: Mac keyboard shortcuts

Shift–Command–Minus sign (-): Decrease the size of the selected item.

Shift–Command–Plus sign (+): Increase the size of the selected item. Command–Equal sign (=) performs the same function.```

Also, the Cmd + Shift shortcuts are not listed in the Apple Terminal guide

[mdznr]

You should be able to just set ⌘+ as the menu item’s key equivalent and AppKit will do the keyboard localization for you for this well-known key equivalent. This is inspectable in other apps that have similar menu items (Safari, TextEdit, Preview, Terminal, and others).

I verified locally that removing:

    try result.keybind.set.put(
        alloc,
        .{ .key = .{ .translated = .equal }, .mods = inputpkg.ctrlOrSuper(.{}) },
        .{ .increase_font_size = 1 },
    );

from src/config/Config.zig:2052 and adding:

        GHOSTTY_KEY_PLUS: "+",

to macos/Sources/Ghostty/Ghostty.Input.swift:150 resolves the issue on macOS.
I have not inspected/tested the impact of this on other platforms, though.

[curtbushko]

@mdznr I tried that out and it didn't work for me. Command + Shift + plus just gives me + in the terminal.

Here is my diff:

[curtbushko]

Give this a try and see if it works for you.

[mateossh]

@curtbushko your change fixes issue with shortcut, but there's still something wrong. While testing I noticed that shortcut isn't associated with "increasing font" action in menu bar.

[curtbushko]

@mateossh Interesting. I have Increase Font Size Command =. Even using the default ghostty config I get this. I am using a M1 laptop and I wonder if it is different because of the built in keyboard.

What version of Mac are you on?
Does your regular/downloaded copy of ghostty have the same problem?

[mateossh]

I ran ghostty +show-config --default --docs > ~/.config/ghostty/config when started using Ghostty, but didn't change any keybind.

Without config file I have the same behavior as you but with default config applied I don't have shortcut.

Ghostty 2f6860fb on M3 MacBook Pro with ANSI keyboard, Mac OS Sequoia 15.2.

[curtbushko]

Awesome. Thank you. We must have 2 semi-related bugs here.

[jcollie]

I ran ghostty +show-config --default --docs > ~/.config/ghostty/config when started using Ghostty, but didn't change any keybind.

This is not how we recommend configuring Ghostty as there are a number of ways that this can mess up. Try removing everything except the configuration entries that you changed and try again.