macOS: Handle `toggle_maximize` action

[pluiedev]

Looks like we forgot to consider the toggle maximize action in the macOS apprt (the case for it is simply missing, even among the fallthrough cases:

ghostty/macos/Sources/Ghostty/Ghostty.App.swift

Lines 541 to 553 in 17ba025

	case GHOSTTY_ACTION_CLOSE_ALL_WINDOWS:
	fallthrough
	case GHOSTTY_ACTION_TOGGLE_TAB_OVERVIEW:
	fallthrough
	case GHOSTTY_ACTION_TOGGLE_WINDOW_DECORATIONS:
	fallthrough
	case GHOSTTY_ACTION_PRESENT_TERMINAL:
	fallthrough
	case GHOSTTY_ACTION_SIZE_LIMIT:
	fallthrough
	case GHOSTTY_ACTION_QUIT_TIMER:
	Ghostty.logger.info("known but unimplemented action action=\(action.tag.rawValue)")
	return false

)... I wonder if we could implement some sort of validation to make sure we do handle all known enum cases.

I'm not sure if you could maximize a window on macOS à la Linux or Windows, but even then we should explicitly mark it as an unsupported but known action.

[00-kat]

(Cross-reference: originally from discussion #7028.)

[mitchellh]

I wonder if we could implement some sort of validation to make sure we do handle all known enum cases.

It'd have to be static analysis or codegen. Swift doesn't have compiler-enforced exhaustive enums for C bridging.

[mitchellh]

And for the macOS background: macOS does not have a "maximized" state afaik. It has a "zoom" state: the Windows-style "maximize" button historically expands the window only large enough to fit all of the desired content. I think it's fair for this toggle though to be documented that the window will be enlarged to fit the visible bounds of the screen according to the apprt (e.g. macOS "visible bounds" is a well defined concept).

[pluiedev]

That totally makes sense, as long as something is there I'm happy with it