Looks like Ubuntu 24.04's blueprint-compiler is way too old, and that's causing Snap builds to fail. cc @ghostty-org/snap perhaps we have to make the Snap build via a source tarball which has all the blueprints precompiled

Looks like Ubuntu 24.04's blueprint-compiler is way too old, and that's causing Snap builds to fail. cc @ghostty-org/snap perhaps we have to make the Snap build via a source tarball which has all the blueprints precompiled

#6831

#6831 merged, should fix snap on rebase.

I wonder if in the future (another PR), we should add a headerbar button for this.

I wonder if in the future (another PR), we should add a headerbar button for this.

I was thinking about that too, but things are already getting busy up there. Esp if you're an old timer like me and enable the maximize/minimize buttons.

I checked GNOME Builder to see if there was something there, but nope. Anyway something to keep in the back of the mind.

I also wonder if ctrl+enter will catch on for this in the GNOME HIG. That's the keybind that Builder uses.

I also wonder if ctrl+enter will catch on for this in the GNOME HIG. That's the keybind that Builder uses.

That seems like a problematic keybind we’d have to diverge from. It’s a very popular binding for shells and editors. One of the first I hear about if I break it :) there are a few like that where we had to diverge since control alone is used for many terminal things.

I'm not sure how much I like the focus ring for marking focus. I think I like what GNOME Builder does a bit more. It also seems to be what we do in the mac runtime according to this image:

I think the most glaring issue is that when the focus ring transits the bottom of the dialog, which can be seen in your video at ~7 seconds, it looks like its just chopped off. Here is GNOME Builder in comparison:

To me, it seems a bit cleaner. Give that I mentioned the mac runtime also uses a similar pattern, I'm hoping to generate some discussion.

Another design thing: I like what the Builder dialog does where the entry bleeds into the top of the command palette (no visible entry). Again, also seems to be what we do in the mac runtime.

Take these design comments with a grain of salt because we could tackle them in a subsequent PR if we think there are improvements to be made :)

Just want to note that the UX doesn't need to match macOS exactly. Comparing the two is always a healthy tension but happy to merge this and iterate on it (similar to what macOS is doing now).

Just want to note that the UX doesn't need to match macOS exactly

Agree, just wanted to acknowledge prior design art.

The thing is that the way GNOME Builder does it is... awfully complex. We're talking a custom reimplementation of the search bar widget, hacking around how selection and focus works, and in general it's super bespoke. I think an off-the-shelf solution is better for now, and we could always reiterate on this later