macOS: mouse events in first row on screen (first ever, after scrolling is fine) not working

[mitchellh]

#9409

I think something in the NSScrollView is blocking it. I've verified this is at the macOS layer, not the core layer.

Reproduce:

1. Open Ghostty
2. Double click the top row to try to highlight something.

If you create one line of scroll back everything works fine.

[mitchellh]

Through some debugging I've determined the NSClipView is intercepting these events. I don't know why yet.

[danielwe]

It's kind of incidental, but #9291 fixes this as it pulls the surface view out of the subview tree of the NSClipView

[mitchellh]

Yeah I thought it might, but that's a big PR I want to think more about and was hoping we could find an interim fix.

[danielwe]

But of course there are design questions there, so probably shouldn't rush to merge that. EDIT: jinx

[mitchellh]

Yeah what I've found is that documentHeight calculation with the padding is causing the surface view bounds to not actually be the full content view so it's missing some events. If I revert all that it all works fine, but then obviously the bug you fix gets reintroduced.

[danielwe]

Yeah I see it now, when layout is first called, documentView.frame isn't necessarily initialized to the kind of size it would have after a scrollbar update, which is assumed in those calculations. This diff fixes it. I can PR if this looks like a satisfactory solution?

diff --git i/macos/Sources/Ghostty/SurfaceScrollView.swift w/macos/Sources/Ghostty/SurfaceScrollView.swift
index 2a9e49d9a..ed4c31de2 100644
--- i/macos/Sources/Ghostty/SurfaceScrollView.swift
+++ w/macos/Sources/Ghostty/SurfaceScrollView.swift
@@ -177,7 +177,7 @@ class SurfaceScrollView: NSView {
         // Keep document width synchronized with content width, and
         // recalculate the height of the document view to account for the
         // change in padding around the cell grid due to the resize.
-        var documentHeight = documentView.frame.height
+        var documentHeight = max(documentView.frame.height, contentSize.height)
         let cellHeight = surfaceView.cellSize.height
         if cellHeight > 0 {
             let oldPadding = fmod(documentHeight, cellHeight)