Skip to content

Commit d86837e

Browse files
committed
fixed some parameter handling
1 parent 0b2a940 commit d86837e

File tree

4 files changed

+15
-6
lines changed

4 files changed

+15
-6
lines changed

.github/workflows/publish-container.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
tags: |
4141
# set latest tag for default branch
4242
type=raw,value=latest
43-
type=raw,value=v1.0.2
43+
type=raw,value=v1.0.3
4444
# This step uses the `docker/build-push-action` action to build the image, based on your repository's `Dockerfile`. If the build succeeds, it pushes the image to GitHub Packages.
4545
# It uses the `context` parameter to define the build's context as the set of files located in the specified path. For more information, see "[Usage](https://github.com/docker/build-push-action#usage)" in the README of the `docker/build-push-action` repository.
4646
# It uses the `tags` and `labels` parameters to tag and label the image with the output from the "meta" step.

clowm/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# SANS Changelog
22

3+
4+
## v1.0.3 [2025-02-07]
5+
6+
### Fixed
7+
8+
- consensus planar was missing in parameter definitions
9+
- some filtering combinations with tree/strict were not handled properly
10+
311
## v1.0.2 [2025-02-0]
412

513
### Fixed

clowm/main.nf

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ params.file_of_files = "$projectDir/NO_FILE3"
88
params.blacklist = "$projectDir/NO_FILE4"
99

1010
process sans {
11-
container "ghcr.io/gi-bielefeld/sans:v1.0.2"
11+
container "ghcr.io/gi-bielefeld/sans:v1.0.3"
1212
publishDir params.outdir, mode: 'symlink'
1313
debug false
1414
label 'highmemMedium'
@@ -79,7 +79,7 @@ process sans {
7979
${ params.consensus == "none" && params.filter == 'strict' ? "--newick sans_tree.newick" : '' } \
8080
${ params.consensus == "none" && params.filter == '2-tree' ? "--newick sans_tree.newick" : '' } \
8181
${ params.consensus == "none" && params.filter == '3-tree' ? "--newick sans_tree.newick" : '' } \
82-
${ params.consensus == "tree" ? "--newick sans_tree.newick" : '' } \
82+
${ params.consensus == "strict" ? "--newick sans_tree.newick" : '' } \
8383
${ params.consensus == "2-tree" ? "--newick sans_tree.newick" : '' } \
8484
${ params.consensus == "3-tree" ? "--newick sans_tree.newick" : '' } \
8585
${ params.consensus == "none" && params.filter == 'weakly' ? "--nexus sans_splitnetwork.nexus" : '' } \
@@ -101,15 +101,15 @@ process sans {
101101
${ params.top != null ? "--top ${ params.top }" : "" } \
102102
${ params.pdf && params.consensus == "none" && params.filter == 'strict' ? "--svg sans_tree.svg" : "" } \
103103
${ params.pdf && params.consensus == "none" && params.filter != 'strict' ? "--svg sans_splitnetwork.svg" : "" } \
104-
${ params.pdf && params.consensus == "tree" ? "--svg sans_tree.svg" : "" } \
104+
${ params.pdf && params.consensus == "strict" ? "--svg sans_tree.svg" : "" } \
105105
${ params.pdf && params.consensus != "none" && params.consensus != "strict" ? "--svg sans_splitnetwork.svg" : "" } \
106106
${ params.svg && params.consensus == "none" && params.filter == 'strict' ? "--svg sans_tree.svg" : "" } \
107107
${ params.svg && params.consensus == "none" && params.filter != 'strict' ? "--svg sans_splitnetwork.svg" : "" } \
108-
${ params.svg && params.consensus == "tree" ? "--svg sans_tree.svg" : "" } \
108+
${ params.svg && params.consensus == "strict" ? "--svg sans_tree.svg" : "" } \
109109
${ params.svg && params.consensus != "none" && params.consensus != "strict" ? "--svg sans_splitnetwork.svg" : "" } \
110110
${ params.filter == 'strict' ? "--filter strict" : '' } \
111111
${ params.filter == 'weakly' ? "--filter weakly" : '' } \
112-
${ params.filter == 'planar' ? "--filter weakly" : '' } \
112+
${ params.filter == 'planar' ? "--filter planar" : '' } \
113113
${ params.filter == '2-tree' ? "--filter 2-tree" : '' } \
114114
${ params.filter == '3-tree' ? "--filter 3-tree" : '' } \
115115
${ params.filter == 'default' ? "--filter weakly" : '' } \

clowm/nextflow_schema.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,7 @@
158158
"enum": [
159159
"strict",
160160
"weakly",
161+
"planar",
161162
"2-tree",
162163
"3-tree",
163164
"none"

0 commit comments

Comments
 (0)