Skip to content

ImagePullSecrets not working #203

Open
@ynctlm

Description

Hi,

I guess the imagePullSecrets in the Helm chart are not working.

I think there are two issues:

  1. The type is currently object, it has to be array.

Fix for values.schema.json

      ...
      "imagePullSecrets": {
        "type": "array"
      `},`
      ...

Fix for values.yaml

...
imagePullSecrets: []
...
  1. The indentation of the imagePullSecret property in the deployment.yaml is off.

Fix for deployment.yaml

      ...
      securityContext:
        runAsUser: {{ .Values.pod.user.id }}
        runAsGroup: {{ .Values.pod.group.id }}
        {{- with .Values.podSecurityContext }}
          {{- . | toYaml | nindent 8 }}
        {{- end }}
      {{- with .Values.imagePullSecrets }}
      imagePullSecrets:
        {{- toYaml . | nindent 8 }}
      {{- end }}
      containers:
      ...

Maybe there is also another solution to fix this, but this is how I got it working locally.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions