update event delete logic to soft delete --makes more sense

Author: gigacache

app/src/Controller/Api/EventsController.php

@@ -3,6 +3,7 @@
 
 namespace App\Controller\Api;
 
+use App\Model\Entity\Event;
 use Cake\Datasource\Exception\RecordNotFoundException;
 
 class EventsController extends ApiController
@@ -145,7 +146,6 @@ public function update()
     public function delete(string $id)
     {
         $this->validateRequest('DELETE');
-        // can do this in the cakephp5 middleware but to make it simple
         if (!$this->authenticate()) {
             return;
         }
@@ -162,20 +162,22 @@ public function delete(string $id)
             return;
         }
 
-        if (!$this->Events->delete($event)) {
+        $event->set('status', Event::STATUS_CANCELLED);
+
+        if ($this->Events->save($event)) {
             $this->buildResponse([
-                'success' => false,
-                'message' => 'Unable to delete event',
-                'errors' => $event->getErrors(),
-            ], 400);
+                'success' => true,
+                'message' => 'Event has been cancelled.',
+                'errors' => null,
+            ], 200);
 
             return;
         }
 
         $this->buildResponse([
-            'success' => true,
-            'message' => 'Event deleted successfully',
-            'errors' => null,
-        ], 200);
+            'success' => false,
+            'message' => 'Unable to cancel event.',
+            'errors' => $event->getErrors(),
+        ], 400);
     }
 }

app/tests/TestCase/Controller/Api/EventsControllerTest.php

@@ -3,6 +3,7 @@
 
 namespace App\Test\TestCase\Controller\Api;
 
+use App\Model\Entity\Event;
 use App\Model\Table\EventsTable;
 use Cake\TestSuite\IntegrationTestTrait;
 use Cake\TestSuite\TestCase;
@@ -125,7 +126,7 @@ public function testGetEvents(): void
     }
 
     /**
-     * Test deleting events (DELETE request)
+     * Test cancelling events (DELETE request / soft delete)
      */
     public function testDeleteEvent(): void
     {
@@ -147,20 +148,22 @@ public function testDeleteEvent(): void
         $this->post('/api/events/create', json_encode($createData));
         $response = json_decode((string)$this->_response->getBody(), true);
         $eventId = $response['event']['id'];
-
         $this->configRequest([
             'headers' => [
                 'Authorization' => self::HOMERS_FIXTURE_TOKEN,
                 'Accept' => 'application/json',
             ],
         ]);
-
         $this->delete('/api/events/delete/' . $eventId);
         $this->assertResponseCode(200);
         $this->assertContentType('application/json');
+
         $response = json_decode((string)$this->_response->getBody(), true);
         $this->assertTrue($response['success']);
-        $this->assertSame('Event deleted successfully', $response['message']);
+        $this->assertSame('Event has been cancelled.', $response['message']);
+
+        $event = $this->Events->get($eventId);
+        $this->assertSame(Event::STATUS_CANCELLED, $event->status);
     }
 
     /**