`cannot use libphonenumber\timezone\data\Map`

[GrahamCampbell]

Since 9.0.0 we're seeing this error:

cannot use libphonenumber\timezone\data\Map - it is not a trait

[giggsey]

Hi, do you have a code example or a stack trace that shows where this error is coming from.

This library has never used any traits

[GrahamCampbell]

This is a fatal error, and has no trace, unfortunately.

[GrahamCampbell]

I have a feeling this is a PHP bug caused by loading a massive amount of classes. I'm going to roll back to v8 of this library.

[giggsey]

Any reproducible code example?

A vague error isn't really much to go on

[GrahamCampbell]

It's not re-producable. Around 1 in a million production requests we have are failing with this error.

[giggsey]

What sort of functionality are you using from the library and which PHP version/setup

I'll try to run some mass load tests next week

[GrahamCampbell]

We're using PHP 8.3.19 on Amazon Linux 2 (Lambda) with Laravel 10 (the collect function in the below code example comes from there). This is the class we have that uses this library:

<?php

declare(strict_types=1);

namespace Acme\PhoneUtils;

use DateTimeZone;
use Exception;
use libphonenumber\NumberParseException;
use libphonenumber\PhoneNumberToTimeZonesMapper;
use libphonenumber\PhoneNumberType;
use libphonenumber\PhoneNumberUtil;

final class PhoneTimeZone
{
    public static function lookupTimeZone(string $phone): ?DateTimeZone
    {
        if (!str_starts_with($phone, '+1')) {
            return null;
        }

        $phoneNumberUtil = PhoneNumberUtil::getInstance();

        try {
            $phoneNumber = $phoneNumberUtil->parse($phone, 'US');
        } catch (NumberParseException) {
            return null;
        }

        $numberType = $phoneNumberUtil->getNumberType($phoneNumber);

        if (
            PhoneNumberType::UNKNOWN === $numberType
            || !$phoneNumberUtil->isNumberGeographical($numberType, $phoneNumber->getCountryCode())
        ) {
            return null;
        }

        $timeZoneMapper = PhoneNumberToTimeZonesMapper::getInstance();

        return collect($timeZoneMapper->getTimeZonesForGeographicalNumber($phoneNumber))
            ->flatMap(function (string $timeZone): array {
                try {
                    /** @psalm-suppress ArgumentTypeCoercion */
                    return [
                        new DateTimeZone($timeZone),
                    ];
                } catch (Exception $e) {
                    return [];
                }
            })
            ->first();
    }
}

[giggsey]

I haven't been able to reproduce this issue. My test script was calling your function (changing the Collection to a simple foreach) in a loop, and happily ran for 10 million iterations.

This library now has around 1000 classes, which is around the same size as the laravel/framework itself.

[GrahamCampbell]

I think the problem is actually loading all of the classes, not just them existing on disk.

[GrahamCampbell]

I gotta assume the large amount of data in constants is causing memory corruption. We don't ever see the crash calling your code, we see it in some other unrelated situation.

[giggsey]

I'm going to leave this open for now, but not actively look into it.