fix: resolve all compile warnings and FunctionClauseError

Found by running `mix test --warnings-as-errors`:

  * watcher.ex:169 — FunctionClauseError accessing id on a tuple
    because render_timeline_diff passed the full JSON response
    (%{"records": [...]}) to new_records/2 instead of extracting
    the records list. Fixed with %{"records" => records} pattern.
  * watcher_test.exs — unused build_id, log_id → _build_id, _log_id
  * pull_requests_test.exs — 8 tests with unused server binding → _server
  * teams_test.exs — unused alias Teams → removed
  * releases_test.exs — unused alias Releases → removed
  * whoami_test.exs — unused alias Whoami → removed
  * schema_test.exs — unused import CliMate.CLI → removed
  * output_test.exs — unused import CliMate.CLI → removed
  * pull_requests_test.exs — unused alias PullRequests → removed

317 tests pass, 0 warnings, mix ci 8/8 green.

Author: gilbertwong96

lib/ado_cli/ci/watcher.ex

@@ -152,7 +152,7 @@ defmodule AdoCli.CI.Watcher do
   # Each record represents a job, task, or phase in the pipeline.
   defp render_timeline_diff(state, print) do
     case fetch_timeline(state.build_id, state.project, state.org) do
-      {:ok, records} ->
+      {:ok, %{"records" => records}} ->
         Enum.each(new_records(state.last_timeline, records), fn rec ->
           print_record(rec, print)
         end)

test/ado_cli/ci/watcher_test.exs

@@ -124,8 +124,8 @@ defmodule AdoCli.CI.WatcherTest do
   # integration test in the docs.
   defp run_with_mocked_log(opts) do
     parent = self()
-    log_id = opts[:log_id]
-    build_id = opts[:build_id]
+    _log_id = opts[:log_id]
+    _build_id = opts[:build_id]
     lines = opts[:lines]
     body = Enum.join(lines, "\n") <> "\n"
 

test/ado_cli/cli/output_test.exs

@@ -2,7 +2,6 @@ defmodule AdoCli.CLI.OutputTest do
   use ExUnit.Case, async: false
 
   import ExUnit.CaptureIO
-  import CliMate.CLI
   alias AdoCli.CLI.Output
 
   setup do

test/ado_cli/cli/pull_requests_test.exs

@@ -1,7 +1,6 @@
 defmodule AdoCli.CLI.PullRequestsTest do
   use AdoCli.CLI.TestHelper
   import ExUnit.CaptureIO
-  alias AdoCli.CLI.PullRequests
 
   describe "list_prs" do
     test "halts 0 on successful get", %{server: server} do
@@ -171,7 +170,7 @@ defmodule AdoCli.CLI.PullRequestsTest do
       )
     end
 
-    test "halts 1 on API error", %{server: server} do
+    test "halts 1 on API error", %{server: _server} do
       # complete_pr uses PATCH, not GET. The generic expect_api_error
       # helper mocks GET so this test was incorrectly written. Skipping
       # for now — the success path above exercises the code.
@@ -414,7 +413,7 @@ defmodule AdoCli.CLI.PullRequestsTest do
       assert msg =~ "No change matches --file 'src/does_not_exist.ex'"
     end
 
-    test "halts 1 with --file and --unified set together", %{server: server} do
+    test "halts 1 with --file and --unified set together", %{server: _server} do
       capture_io(fn ->
         apply(AdoCli.CLI.PullRequests, :diff_pr, [
           %{
@@ -686,7 +685,7 @@ defmodule AdoCli.CLI.PullRequestsTest do
       )
     end
 
-    test "halts 1 with a clear error on invalid --status", %{server: server} do
+    test "halts 1 with a clear error on invalid --status", %{server: _server} do
       # No expectation registered: the function must halt BEFORE
       # the HTTP call. If the function ever hits the network,
       # the test fails with "no expectation matched".
@@ -796,7 +795,7 @@ defmodule AdoCli.CLI.PullRequestsTest do
     end
 
     test "halts 1 with a clear error when --content @<missing-file> cannot be read",
-         %{server: server} do
+         %{server: _server} do
       missing = "/tmp/ado-missing-#{System.unique_integer([:positive])}.md"
 
       capture_io(fn ->
@@ -1010,7 +1009,7 @@ defmodule AdoCli.CLI.PullRequestsTest do
   # ── update_comment (prs comments update) ─────────────────────────
 
   describe "update_comment (prs comments update)" do
-    test "halts 1 when neither --content nor --status is given", %{server: server} do
+    test "halts 1 when neither --content nor --status is given", %{server: _server} do
       capture_io(fn ->
         apply(AdoCli.CLI.PullRequests, :update_comment, [
           %{
@@ -1115,7 +1114,7 @@ defmodule AdoCli.CLI.PullRequestsTest do
       assert_receive {:cli_mate_shell, :halt, 0}, 500
     end
 
-    test "halts 1 with a clear error on invalid --status", %{server: server} do
+    test "halts 1 with a clear error on invalid --status", %{server: _server} do
       capture_io(fn ->
         apply(AdoCli.CLI.PullRequests, :update_comment, [
           %{
@@ -1199,7 +1198,7 @@ defmodule AdoCli.CLI.PullRequestsTest do
     end
 
     test "--dry-run with --content prints the would-be PATCH and halts 0 (no API call)",
-         %{server: server} do
+         %{server: _server} do
       output =
         capture_io(fn ->
           apply(AdoCli.CLI.PullRequests, :update_comment, [
@@ -1232,7 +1231,7 @@ defmodule AdoCli.CLI.PullRequestsTest do
       assert action["body"] == %{"content" => "new text"}
     end
 
-    test "--dry-run with --status prints the would-be thread PATCH", %{server: server} do
+    test "--dry-run with --status prints the would-be thread PATCH", %{server: _server} do
       output =
         capture_io(fn ->
           apply(AdoCli.CLI.PullRequests, :update_comment, [

test/ado_cli/cli/releases_test.exs

@@ -1,6 +1,5 @@
 defmodule AdoCli.CLI.ReleasesTest do
   use AdoCli.CLI.TestHelper
-  alias AdoCli.CLI.Releases
 
   describe "list_releases" do
     test "halts 0 on successful get", %{server: server} do

test/ado_cli/cli/schema_test.exs

@@ -2,7 +2,6 @@ defmodule AdoCli.CLI.SchemaTest do
   use ExUnit.Case, async: false
   import ExUnit.CaptureIO
 
-  import CliMate.CLI
   alias AdoCli.CLI.Schema
 
   describe "build_tree/0" do

test/ado_cli/cli/teams_test.exs

@@ -1,6 +1,5 @@
 defmodule AdoCli.CLI.TeamsTest do
   use AdoCli.CLI.TestHelper
-  alias AdoCli.CLI.Teams
 
   describe "list_teams" do
     test "halts 0 on successful get", %{server: server} do

test/ado_cli/cli/whoami_test.exs

@@ -1,6 +1,5 @@
 defmodule AdoCli.CLI.WhoamiTest do
   use AdoCli.CLI.TestHelper
-  alias AdoCli.CLI.Whoami
 
   describe "run" do
     test "halts 0 on success" do